8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"

[raviniitw2012]

CloseInflaterDeflaterTest.java is failing intermittently(Observed once in macOS and Linux), testInflaterOutputStream() is added as an extra test as part of https://bugs.openjdk.java.net/browse/JDK-8278794. Disabling this test for now before debugging any timing issues in Inflater.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8213/head:pull/8213
$ git checkout pull/8213

Update a local copy of the PR:
$ git checkout pull/8213
$ git pull https://git.openjdk.java.net/jdk pull/8213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8213

View PR using the GUI difftool:
$ git pr show -t 8213

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8213.diff

[bridgekeeper]

👋 Welcome back rreddy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@raviniitw2012 The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1b56a8f9)

[LanceAndersen]

Hi Ravi,

Yes, makes sense to disable the test to keep Mach5 happy given this failure is very very intermittent while you try to chase down whether it is an implementation or test issue

[openjdk]

@raviniitw2012 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"

Reviewed-by: lancea

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@LanceAndersen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[raviniitw2012]

/integrate

[LanceAndersen]

/sponsor

[openjdk]

@raviniitw2012
Your change (at version 1b56a8f) is now ready to be sponsored by a Committer.

[openjdk]

Going to push as commit 7891085.

[openjdk]

@LanceAndersen @raviniitw2012 Pushed as commit 7891085.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.