8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues

[prrace]

This test had problem described in the bug report, and most of it was related to being headful.
But actually the test didn't need to be headful - it did the actual rendering it wanted to test to
a software BufferedImage. So make it headless.
Also only Windows always supports LCD text, so run the test there and not Linux or Mac.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Alexander Zvegintsev (@azvegint - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8227/head:pull/8227
$ git checkout pull/8227

Update a local copy of the PR:
$ git checkout pull/8227
$ git pull https://git.openjdk.java.net/jdk pull/8227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8227

View PR using the GUI difftool:
$ git pr show -t 8227

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8227.diff

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (67dacc12)

[mrserb]

Are there any differences in rendering LCD to the buffered image or to the volatile image?

[prrace]

Are there any differences in rendering LCD to the buffered image or to the volatile image?

There shouldn't be since it is the same code (loops) in both cases. We have to read back from a volatile image to get a s/w surface for LCD text - which is part of why LCD text can be slower than greyscale on some graphics cards where that read back is slow.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues

Reviewed-by: serb, azvegint, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 9a00b43: 8284584: Avoid duplicate node_idx_t definitions
• f264031: 8236987: Remove call to System.out.println from ImageIcon.loadImage
• 339005d: 8284816: Make markWord::has_monitor() more robust
• 2ba5cc4: 8284760: Correct type/array element offset in LibraryCallKit::get_state_from_digest_object()
• c3938ec: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
• 23c6817: 6626492: Event time in future part 2, now on X
• 2241a05: 8284578: Relax InterpreterCodelet stub alignment
• bf85b00: 8284564: Extend VectorAPI validation tests for SHIFTs and ROTATE operations with constant shift values.
• bf1c3ef: 8284775: Simplify String.substring(_, length()) calls
• 249d54f: 8284673: Collapse identical catch branches in java.management
• ... and 21 more: https://git.openjdk.java.net/jdk/compare/4e165f66a954dd7fab4b6dab584c4da060f6a48e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

Going to push as commit d41331e.
Since your change was applied there have been 38 commits pushed to the master branch:

• 3084921: 8284894: Fix typos in langtools
• fbb0916: 8283892: Compress and expand bits
• 160eb2b: 8284891: Fix typos in build system files
• 48c7549: 8284853: Fix various 'expected' typo
• a81c5d3: 8284635: Crashes after 8282221: assert(ctrl == kit.control()) failed: Control flow was added although the intrinsic bailed out
• 3ffec3a: 8284866: Add test to JDK-8273056
• 1cc3c33: 8283864: Clean up DocFinder and friends
• 9a00b43: 8284584: Avoid duplicate node_idx_t definitions
• f264031: 8236987: Remove call to System.out.println from ImageIcon.loadImage
• 339005d: 8284816: Make markWord::has_monitor() more robust
• ... and 28 more: https://git.openjdk.java.net/jdk/compare/4e165f66a954dd7fab4b6dab584c4da060f6a48e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit d41331e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.