8255285: Move JVMFlag origins into a new enum JVMFlagOrigin #823
On 23/10/2020 4:52 pm, Ioi Lam wrote:
I'm still confused :) Why are we reporting "command line" for a flag
Why not define this as
enum class Origin
inside class JVMFlag, so that it is then referred to as JVMFlag::Origin?
Why is this needed?? To avoid re-typing JVMFlagOrigin?
We have code like this:
So if FLAG_SET_ERGO changes a flag that was specified in the command-line, we will print out "command line, ergonomic".
I have no idea why this is the case. Maybe ergonomics is allowed to "fine tune" user-specified values? Anyway, if we want to change this, we should do it in a separate RFE.
The reason is to allow
A nested enum like
Yeah, but I removed this in the latest version 53fed1b
@iklam This change now passes all automated pre-integration checks.
ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been no new commits pushed to the
➡️ To integrate this PR with the above commit message to the
On 27/10/2020 8:32 am, Ioi Lam wrote:
Yes separate RFE. This might be necessary/desirable but at a minimum it
That is a pity. I'm not sure I agree with the overall approach of making