Skip to content

6626492: Event time in future part 2, now on X#8232

Closed
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:6626492_CorrectTime
Closed

6626492: Event time in future part 2, now on X#8232
azvegint wants to merge 1 commit intoopenjdk:masterfrom
azvegint:6626492_CorrectTime

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Apr 13, 2022

This fix simply remove the test from ProblemList, since the issue is no longer reproducible.

Multiple CI test runs are green.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8232/head:pull/8232
$ git checkout pull/8232

Update a local copy of the PR:
$ git checkout pull/8232
$ git pull https://git.openjdk.java.net/jdk pull/8232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8232

View PR using the GUI difftool:
$ git pr show -t 8232

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8232.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@azvegint To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@azvegint
Copy link
Member Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 13, 2022
@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@azvegint
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2022

Webrevs

Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I think it was fixed as part of JDK-7194219

@openjdk
Copy link

openjdk bot commented Apr 13, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6626492: Event time in future part 2, now on X

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2022
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 14, 2022

Going to push as commit 23c6817.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 2241a05: 8284578: Relax InterpreterCodelet stub alignment
  • bf85b00: 8284564: Extend VectorAPI validation tests for SHIFTs and ROTATE operations with constant shift values.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 14, 2022
@openjdk openjdk bot closed this Apr 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 14, 2022
@openjdk
Copy link

openjdk bot commented Apr 14, 2022

@azvegint Pushed as commit 23c6817.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants