-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8284858: Start of release updates for JDK 20 #8236
Conversation
👋 Welcome back darcy! A progress list of the required criteria for merging this PR into |
@jddarcy The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
langtools files look OK, although I did skim through the auto-generated new data/symbols files.
There are possibilities in the langtools file to simplify naming and default initialization of member fields in various places, in a separate PR, separate from these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes still look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build changes look good. Thanks for fixing the bug in generate-symbol-data.sh
.
/integrate defer |
@jddarcy Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command. |
/integrate |
Going to push as commit edff51e.
Your commit was automatically rebased without conflicts. |
Time to start getting ready for JDK 20...
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8236/head:pull/8236
$ git checkout pull/8236
Update a local copy of the PR:
$ git checkout pull/8236
$ git pull https://git.openjdk.java.net/jdk pull/8236/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8236
View PR using the GUI difftool:
$ git pr show -t 8236
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8236.diff