Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java #8244

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Apr 14, 2022

The SimpleWindowActivationTest test does not fail even without modifications(multiple CI test runs are green).
So just remove it from ProblemList would be enough.

However I did some clean up and added some delays for "extra safety".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8244/head:pull/8244
$ git checkout pull/8244

Update a local copy of the PR:
$ git checkout pull/8244
$ git pull https://git.openjdk.java.net/jdk pull/8244/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8244

View PR using the GUI difftool:
$ git pr show -t 8244

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8244.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java Apr 14, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2022
@openjdk
Copy link

openjdk bot commented Apr 14, 2022

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 14, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 4cc8ecc: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown
  • 53580b3: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • bdf8a2a: 8283326: Implement SafeFetch statically
  • bb7c97b: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem
  • 1e22c70: 8284892: java/net/httpclient/http2/TLSConnection.java fails intermittently
  • 510003c: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException
  • ea0706d: 8284863: riscv: missing side effect for result in instruct vcount_positives
  • d970820: 8284796: sun.security.ssl.Finished::toString misses a line feed in the message format pattern
  • d41331e: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues
  • 3084921: 8284894: Fix typos in langtools
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/9a00b432eab01918f99e7a37ba0cc832ef3a1a58...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2022
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 16, 2022

Going to push as commit f5beafa.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 21de4e5: 8284681: compiler/c2/aarch64/TestFarJump.java fails with "RuntimeException: for CodeHeap < 250MB the far jump is expected to be encoded with a single branch instruction"
  • 9695283: 8240903: Add test to check that jmod hashes are reproducible
  • dce7240: 8284921: tier1 test failures after JDK-8284909
  • 9f97f5d: 8283704: Add sealed modifier to java.awt.MultipleGradientPaint
  • 1ebf2f0: 8284909: [JVMCI] remove remnants of AOT support
  • 6199008: 8284914: Problem list test(s) failing due to extra repaints with D3D pipeline.
  • 4cc8ecc: 8280915: Better parallelization for AbstractSpliterator and IteratorSpliterator when size is unknown
  • 53580b3: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java
  • bdf8a2a: 8283326: Implement SafeFetch statically
  • bb7c97b: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/9a00b432eab01918f99e7a37ba0cc832ef3a1a58...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2022
@openjdk openjdk bot closed this Apr 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2022
@openjdk
Copy link

openjdk bot commented Apr 16, 2022

@azvegint Pushed as commit f5beafa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants