Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException #8257

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 15, 2022

This test used to fail in nightly testing few years back and it seems it fails because we used to run in samevm mode at that time.
Several iterations of this test pass in CI testing in all platforms (link in JBS) so removing from Problemlist.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8257/head:pull/8257
$ git checkout pull/8257

Update a local copy of the PR:
$ git checkout pull/8257
$ git pull https://git.openjdk.java.net/jdk pull/8257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8257

View PR using the GUI difftool:
$ git pr show -t 8257

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8257.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2022
@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 15, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 15, 2022

Going to push as commit 510003c.
Since your change was applied there have been 14 commits pushed to the master branch:

  • ea0706d: 8284863: riscv: missing side effect for result in instruct vcount_positives
  • d970820: 8284796: sun.security.ssl.Finished::toString misses a line feed in the message format pattern
  • d41331e: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues
  • 3084921: 8284894: Fix typos in langtools
  • fbb0916: 8283892: Compress and expand bits
  • 160eb2b: 8284891: Fix typos in build system files
  • 48c7549: 8284853: Fix various 'expected' typo
  • a81c5d3: 8284635: Crashes after 8282221: assert(ctrl == kit.control()) failed: Control flow was added although the intrinsic bailed out
  • 3ffec3a: 8284866: Add test to JDK-8273056
  • 1cc3c33: 8283864: Clean up DocFinder and friends
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/c3938ec18b4026d70d9654235dcd986d90344f5b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 15, 2022
@openjdk openjdk bot closed this Apr 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2022
@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@prsadhuk Pushed as commit 510003c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8042380 branch April 15, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants