-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException #8257
Conversation
…with InvocationTargetException
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 510003c.
Your commit was automatically rebased without conflicts. |
This test used to fail in nightly testing few years back and it seems it fails because we used to run in samevm mode at that time.
Several iterations of this test pass in CI testing in all platforms (link in JBS) so removing from Problemlist.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8257/head:pull/8257
$ git checkout pull/8257
Update a local copy of the PR:
$ git checkout pull/8257
$ git pull https://git.openjdk.java.net/jdk pull/8257/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8257
View PR using the GUI difftool:
$ git pr show -t 8257
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8257.diff