Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284909: [JVMCI] remove remnants of AOT support #8263

Closed
wants to merge 1 commit into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented Apr 15, 2022

JDK-8264805 removed Graal from the JDK which included support for using Graal as an AOT compiler (JDK-8166089). There were few bits of support left behind that this PR removes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8263/head:pull/8263
$ git checkout pull/8263

Update a local copy of the PR:
$ git checkout pull/8263
$ git pull https://git.openjdk.java.net/jdk pull/8263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8263

View PR using the GUI difftool:
$ git pr show -t 8263

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8263.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2022

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@dougxc The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Apr 15, 2022
@dougxc dougxc marked this pull request as ready for review April 15, 2022 15:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2022

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284909: [JVMCI] remove remnants of AOT support

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2022
@dougxc
Copy link
Member Author

dougxc commented Apr 15, 2022

Thanks for the prompt review @vnkozlov.

@dougxc
Copy link
Member Author

dougxc commented Apr 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 15, 2022

Going to push as commit 1ebf2f0.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 6199008: 8284914: Problem list test(s) failing due to extra repaints with D3D pipeline.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 15, 2022
@openjdk openjdk bot closed this Apr 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2022
@openjdk
Copy link

openjdk bot commented Apr 15, 2022

@dougxc Pushed as commit 1ebf2f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dougxc dougxc deleted the JDK-8284909 branch May 23, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants