Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255287: aarch64: fix SVE patterns for vector shift count #827

Closed
wants to merge 1 commit into from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Oct 23, 2020

SVE patterns for vector shift count cannot be matched due to bad matching rules.
Also code gen is not correct in certain cases for vlslS_imm and vlsrS_imm.
Please refer to JDK-8255287 for details.
Patch passed tier1 tests using QEMU system emulator which supports SVE.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255287: aarch64: fix SVE patterns for vector shift count

Reviewers

Contributors

  • Yanhong Zhu <zhuyanhong2@huawei.com>

Download

$ git fetch https://git.openjdk.java.net/jdk pull/827/head:pull/827
$ git checkout pull/827

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2020

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@RealFYang The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Oct 23, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2020

Webrevs

@RealFYang
Copy link
Member Author

/contributor add Yanhong Zhu zhuyanhong2@huawei.com

@RealFYang
Copy link
Member Author

/cc hotspot-compiler

@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@RealFYang
Contributor Yanhong Zhu <zhuyanhong2@huawei.com> successfully added.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@RealFYang
The hotspot-compiler label was successfully added.

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look ok.

@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255287: aarch64: fix SVE patterns for vector shift count

Co-authored-by: Yanhong Zhu <zhuyanhong2@huawei.com>
Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2020
@RealFYang
Copy link
Member Author

Thanks for the quick review :-) @adinn

@RealFYang
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Oct 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2020
@RealFYang RealFYang deleted the 8255287 branch October 23, 2020 13:18
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@RealFYang Since your change was applied there have been 6 commits pushed to the master branch:

  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm

Your commit was automatically rebased without conflicts.

Pushed as commit 5ec1b80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants