Skip to content

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 16, 2022

As a convenience to readers, add links from the SourceVersion constants to the particular JLS release they correspond to.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284928: Add links from SourceVersion to specific JLS versions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8275/head:pull/8275
$ git checkout pull/8275

Update a local copy of the PR:
$ git checkout pull/8275
$ git pull https://git.openjdk.java.net/jdk pull/8275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8275

View PR using the GUI difftool:
$ git pr show -t 8275

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8275.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2022
@openjdk
Copy link

openjdk bot commented Apr 16, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Apr 16, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 17, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284928: Add links from SourceVersion to specific JLS versions

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 17, 2022
@jddarcy
Copy link
Member Author

jddarcy commented Apr 18, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2022

Going to push as commit ffdeb32.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d3d71ea: 8284922: Fix some doc-comment issues on methods with package access in JDK API

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2022
@openjdk openjdk bot closed this Apr 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@jddarcy Pushed as commit ffdeb32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy
Copy link
Member Author

jddarcy commented Apr 18, 2022

(The link to a new JLS is only added at the end of a release so I didn't add a link to JLS 19 now since it would be a dead link.)

@jddarcy jddarcy deleted the JDK-8284928 branch June 10, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants