Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284935: Improve debug in java.security.jgss #8279

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Apr 18, 2022

Hi,

May I have the simple update reviewed?

In the java.security.jgss module implementation, some of the debug information could be generated even if debugging is not enabled, which is not resource friendly.

Thanks,
Xuelei


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8279/head:pull/8279
$ git checkout pull/8279

Update a local copy of the PR:
$ git checkout pull/8279
$ git pull https://git.openjdk.java.net/jdk pull/8279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8279

View PR using the GUI difftool:
$ git pr show -t 8279

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8279.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2022

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 18, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2022

Webrevs

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284935: Improve debug in java.security.jgss

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 21ea740: 8284699: Include all image types to the J2DBench.ColorConvertOpTests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 18, 2022
@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 18, 2022

Going to push as commit c63fabe.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ef25e18: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de
  • 21ea740: 8284699: Include all image types to the J2DBench.ColorConvertOpTests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 18, 2022
@openjdk openjdk bot closed this Apr 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@XueleiFan Pushed as commit c63fabe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8284935 branch April 18, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants