Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284949: riscv: Add Zero support for the 32-bit RISC-V architecture #8284

Closed
wants to merge 3 commits into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Apr 18, 2022

This patch adds Zero support for the 32-bit RISC-V architecture.

Additional tests:

  • Linux zero RISCV32 cross-compilation
  • Resulting binaries run on QEMU User mode without problems

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8284949: riscv: Add Zero support for the 32-bit RISC-V architecture

Reviewers

Contributors

  • Junfeng Xie <xiejunfeng3@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8284/head:pull/8284
$ git checkout pull/8284

Update a local copy of the PR:
$ git checkout pull/8284
$ git pull https://git.openjdk.java.net/jdk pull/8284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8284

View PR using the GUI difftool:
$ git pr show -t 8284

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8284.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2022

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 18, 2022
@feilongjiang
Copy link
Member Author

feilongjiang commented Apr 18, 2022

/contributor add Junfeng Xie xiejunfeng3@huawei.com

@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@feilongjiang The following labels will be automatically applied to this pull request:

  • build
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime build labels Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@feilongjiang
Contributor Junfeng Xie <xiejunfeng3@huawei.com> successfully added.

@feilongjiang feilongjiang changed the title 8284949: Add support for 32-bit risc-v zero 8284949: riscv: Add Zero support for the 32-bit RISC-V architecture Apr 18, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2022

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Build change looks good.

@erikj79
Copy link
Member

erikj79 commented Apr 18, 2022

/reviewers 2 reviewer

@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284949: riscv: Add Zero support for the 32-bit RISC-V architecture

Co-authored-by: Junfeng Xie <xiejunfeng3@huawei.com>
Reviewed-by: erikj, stuefe, ihse, yadongwang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • 994f2e9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
  • 691c5da: 8285266: compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java fails after JDK-8284563
  • 94afb36: 8285093: Introduce UTIL_ARG_WITH
  • 8543aaa: 8283839: [JVMCI] add support for querying indy bootstrap method target and arguments
  • 81a8e2f: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • 05ae7ed: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11
  • b2c33f0: 8282120: optimal capacity tests and test library need to be cleaned up
  • d8446b4: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
  • cb16e41: 8283541: Add Statical counters and some comments in PhaseStringOpts
  • 15ce8c6: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/72726c41829b33fd2baf5b3604cab49d39489dd2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @tstuefe, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 18, 2022
@openjdk
Copy link

openjdk bot commented Apr 18, 2022

@erikj79
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with 2 of role reviewers).

@openjdk openjdk bot removed the ready label Apr 18, 2022
Copy link
Member

@tstuefe tstuefe left a comment

LGTM

Cheers, Thomas

P.S. I assume you did not run the whole gamut of jtreg tests, right? Seems to me there are a number of tests which would need to get adapted for riscv32.

@openjdk openjdk bot added the ready label Apr 19, 2022
@feilongjiang
Copy link
Member Author

feilongjiang commented Apr 20, 2022

LGTM

Cheers, Thomas

P.S. I assume you did not run the whole gamut of jtreg tests, right? Seems to me there are a number of tests which would need to get adapted for riscv32.

Thanks for the review, Thomas. Currently, we only test jtreg tier1 tests under test/hotspot and test/jdk on QEMU. I assume it would be enough for adding riscv32 zero support? There are some tests adaptions to be done for riscv32 like [1] [2]. I guess it might be better to fix them in another PR.

[1]

public static boolean isRISCV64() {
return isArch("riscv64");
}

[2]
public class TestMutuallyExclusivePlatformPredicates {
private static enum MethodGroup {
ARCH("isAArch64", "isARM", "isRISCV64", "isPPC", "isS390x", "isX64", "isX86"),
BITNESS("is32bit", "is64bit"),

@feilongjiang
Copy link
Member Author

feilongjiang commented Apr 21, 2022

@erikj79 @tstuefe @yadongw @magicus -- Thanks for the review!
/integrate

@openjdk openjdk bot added the sponsor label Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@feilongjiang
Your change (at version 2b6158f) is now ready to be sponsored by a Committer.

@magicus
Copy link
Member

magicus commented Apr 21, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 21, 2022

Going to push as commit fa04d1f.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 994f2e9: 8284548: Invalid XPath expression causes StringIndexOutOfBoundsException
  • 691c5da: 8285266: compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java fails after JDK-8284563
  • 94afb36: 8285093: Introduce UTIL_ARG_WITH
  • 8543aaa: 8283839: [JVMCI] add support for querying indy bootstrap method target and arguments
  • 81a8e2f: 8284920: Incorrect Token type causes XPath expression to return incorrect results
  • 05ae7ed: 8284291: sun/security/krb5/auto/Renew.java fails intermittently on Windows 11
  • b2c33f0: 8282120: optimal capacity tests and test library need to be cleaned up
  • d8446b4: 8284694: Avoid evaluating SSLAlgorithmConstraints twice
  • cb16e41: 8283541: Add Statical counters and some comments in PhaseStringOpts
  • 15ce8c6: 8284553: Deprecate the DEFAULT static field of OAEPParameterSpec
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/72726c41829b33fd2baf5b3604cab49d39489dd2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 21, 2022
@openjdk openjdk bot closed this Apr 21, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Apr 21, 2022
@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@magicus @feilongjiang Pushed as commit fa04d1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the rv32-zero branch Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build hotspot-runtime integrated
5 participants