8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

[rgiulietti]

Please review these small changes to address intermittent failures, as of JDK-8274517.

• Usage of jdk.test.lib.RandomFactory for reproducible random generation.
• Slightly less restrictive assertion about badParallelStreamError on L94 (former L88).
• Verbatim copy of computeFinalSum() from j.u.s.Collectors 18.

While these changes do not necessarily guarantee absence of intermittent failures, the usage of jdk.test.lib.RandomFactory should at least help to pin down specific double sequences that do not pass the test.

There is still an inherent variability due to the use of parallel streams, though. As double addition is not perfectly associative, even a fully known sequence of doubles may lead to slightly different results with parallelization.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

Reviewers

• Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 769855cd
• Brian Burkhalter (@bplb - Reviewer) ⚠️ Review applies to 769855cd

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8290/head:pull/8290
$ git checkout pull/8290

Update a local copy of the PR:
$ git checkout pull/8290
$ git pull https://git.openjdk.java.net/jdk pull/8290/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8290

View PR using the GUI difftool:
$ git pr show -t 8290

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8290.diff

[bridgekeeper]

👋 Welcome back rgiulietti! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgiulietti The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6035eeab)
• 00: Full (769855cd)

[rgiulietti]

Anybody interested in reviewing?

[AlanBateman]

.

[openjdk]

@rgiulietti This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 034f20f: 8212136: Remove finalizer implementation in SSLSocketImpl
• 36e4df9: 8285516: clearPassword should be called in a finally try block
• b849efd: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
• f143386: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
• 64b05cc: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
• 4f5d73f: 8286294: ForkJoinPool.commonPool().close() spins

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @bplb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[rgiulietti]

/integrate

[openjdk]

@rgiulietti
Your change (at version 769855c) is now ready to be sponsored by a Committer.

[rgiulietti]

Post Loom merge

[rgiulietti]

/integrate

[openjdk]

@rgiulietti
Your change (at version 6035eea) is now ready to be sponsored by a Committer.

[rgiulietti]

After a post Loom merge, this PR lost its sponsor label, so I had to integrate again.
No changes w.r.t. the previous commit.

[AlanBateman]

/sponsor

[openjdk]

Going to push as commit 97a9835.
Since your change was applied there have been 6 commits pushed to the master branch:

• 034f20f: 8212136: Remove finalizer implementation in SSLSocketImpl
• 36e4df9: 8285516: clearPassword should be called in a finally try block
• b849efd: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
• f143386: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
• 64b05cc: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
• 4f5d73f: 8286294: ForkJoinPool.commonPool().close() spins

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman @rgiulietti Pushed as commit 97a9835.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.