Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles #83

Closed
wants to merge 1 commit into from

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Sep 8, 2020

A simple fix to remove two unused import statements and a line of unneeded code from the tests in appcds/dynamicArchive/methodHandles.

Tested locally on linux-x64.
Running mach5 tiers 1 and 2 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/83/head:pull/83
$ git checkout pull/83

@calvinccheung calvinccheung marked this pull request as ready for review September 8, 2020 18:40
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2020

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@calvinccheung The following label will be automatically applied to this pull request: hotspot-runtime.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Sep 8, 2020
@calvinccheung calvinccheung changed the title RFR(T) 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles 8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles Sep 8, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 8, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2020

Webrevs

@iklam
Copy link
Member

iklam commented Sep 8, 2020

Looks good. This is a trivial change.

@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@calvinccheung This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8249625: cleanup unused SkippedException in the tests under cds/appcds/dynamicArchive/methodHandles

Reviewed-by: iklam
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 63a5a12949694015c462f4c705b7809cb7319461.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 8, 2020
@calvinccheung
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 8, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2020
@openjdk
Copy link

openjdk bot commented Sep 8, 2020

@calvinccheung Since your change was applied there have been 3 commits pushed to the master branch:

  • 63a5a12: 8252658: G1: Do not consider G1HeapWastePercent during region selection within a gc
  • 001e51d: 8250563: Add KVHashtable::add_if_absent
  • 91a20ca: 8252695: Shenandoah: clean up Graal enabled/disabled filter in tests

Your commit was automatically rebased without conflicts.

Pushed as commit e20004d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the JDK-8249625 branch October 15, 2020 16:23
caojoshua added a commit to caojoshua/jdk that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants