Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Oct 23, 2020

Following JDK-8254282, it seems useful to also run tier1 tests on 32-bit platform, because that finds problems with runtime tests and internal asserts. Those problems do not show up during the plain build. Again, while x86_32 might not be widely deployed by itself, but 32/64 bit cleanliness detects bugs that manifest on ARM32 early.

I did most of the work to fix all current regressions in x86_32 tier1, the only exception is JDK-8255331, which is supposed to be fixed by #833


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ❌ (1/9 failed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8255305: Add Linux x86_32 tier1 to submit workflow

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/830/head:pull/830
$ git checkout pull/830

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Oct 23, 2020
@shipilev shipilev force-pushed the JDK-8255305-32bit-tier1 branch from 3041440 to ebfb3d5 Compare October 23, 2020 20:31
@shipilev shipilev force-pushed the JDK-8255305-32bit-tier1 branch from ebfb3d5 to 55b4a97 Compare October 26, 2020 12:19
@shipilev shipilev marked this pull request as ready for review October 26, 2020 15:08
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2020

Webrevs

@magicus
Copy link
Member

magicus commented Oct 26, 2020

See my comments in #869

@shipilev
Copy link
Member Author

See my comments in #869

See my comments in #869 as well. Let's integrate this to get the testing going, and then do cosmetic improvements.

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please incorporate the additional fixes in #869 into this PR. That also means that the new code here that mentions "linux-x32" needs to be renamed. After that, you can close #869.

@openjdk
Copy link

openjdk bot commented Oct 27, 2020

⚠️ @shipilev This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@shipilev
Copy link
Member Author

While I am still not sure folding these two together is perfect, did so! Please re-review, @magicus. (Now to wait and see that testing is still fine).

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thank you!

@openjdk
Copy link

openjdk bot commented Oct 27, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255305: Add Linux x86_32 tier1 to submit workflow

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
  • 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
  • 7679650: 8231231: The printing result is different from the case instruction
  • f7c59c6: 8255231: Avoid upcalls when initializing the statSampler
  • dccfd2b: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method
  • d735f91: 8255040: Replace __sync_add_and_fetch with __atomic_add_fetch to avoid build errors with clang
  • bcdeeaa: 8199054: Test javax/swing/UIDefaults/8149879/InternalResourceBundle.java is unstable
  • dee31d0: 8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java
  • abdbbe3: 8254370: Update the classes in the java.awt.color package
  • 8ca59c9: 8255206: [macos] LicenseTest fails on macOS 11
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/7cafe35424c0bdc02a14a6aaaecb1b42fe715f27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 27, 2020
@shipilev
Copy link
Member Author

Testing is still clean apart for missing #833 change. Okay to push then?

@magicus
Copy link
Member

magicus commented Oct 27, 2020

I think you should wait for the problem list. Otherwise you'll introduce intentional test breakage in GH actions.

@shipilev
Copy link
Member Author

#833 is now merged, I am pushing this to get other PRs retested with x86_32.

/integrate

@openjdk openjdk bot closed this Oct 27, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Oct 27, 2020
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 27, 2020
@openjdk
Copy link

openjdk bot commented Oct 27, 2020

@shipilev Since your change was applied there have been 22 commits pushed to the master branch:

  • 66a3917: 8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162
  • cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
  • 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
  • 7679650: 8231231: The printing result is different from the case instruction
  • f7c59c6: 8255231: Avoid upcalls when initializing the statSampler
  • dccfd2b: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method
  • d735f91: 8255040: Replace __sync_add_and_fetch with __atomic_add_fetch to avoid build errors with clang
  • bcdeeaa: 8199054: Test javax/swing/UIDefaults/8149879/InternalResourceBundle.java is unstable
  • dee31d0: 8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java
  • abdbbe3: 8254370: Update the classes in the java.awt.color package
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/7cafe35424c0bdc02a14a6aaaecb1b42fe715f27...master

Your commit was automatically rebased without conflicts.

Pushed as commit 552192f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8255305-32bit-tier1 branch October 27, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants