Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255330: gtest/MetaspaceGtests.java fail on 32-bit platforms #831

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 23, 2020

Seems fairly trivial: UseCompressedKlassPointers is only available on 64-bit platforms.

Attention @tstuefe ;)

Testing:

  • Affected test on Linux x86_64
  • Affected test on Linux x86_32

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255330: gtest/MetaspaceGtests.java fail on 32-bit platforms

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/831/head:pull/831
$ git checkout pull/831

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 23, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@shipilev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 23, 2020

/label hotspot-runtime

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@shipilev
The hotspot-runtime label was successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 23, 2020

Webrevs

Loading

Copy link
Member

@tstuefe tstuefe left a comment

Embarrassingly simple and trivial. Thanks for fixing!

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255330: gtest/MetaspaceGtests.java fail on 32-bit platforms

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • cf821b0: 8232024: Don't pollute log output with multiple errors of the same type
  • 185c8bc: 8255338: CodeSections are never frozen
  • cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
  • 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 23, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 23, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@shipilev Since your change was applied there have been 10 commits pushed to the master branch:

  • cf821b0: 8232024: Don't pollute log output with multiple errors of the same type
  • 185c8bc: 8255338: CodeSections are never frozen
  • cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
  • 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm

Your commit was automatically rebased without conflicts.

Pushed as commit 3f6abd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8255330-32bit-gtest-metaspace branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants