Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274597: Some of the dnd tests time out and fail intermittently #8316

Closed
wants to merge 5 commits into from

Conversation

manukumarvs
Copy link
Member

@manukumarvs manukumarvs commented Apr 20, 2022

These dnd tests fails with a time out intermittently in some machines(mostly Windows 11) which creates frequent noise in CI.

  1. java/awt/dnd/AcceptDropMultipleTimes/AcceptDropMultipleTimes.java
  2. java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
  3. java/awt/dnd/DropTargetEnterExitTest/ExtraDragEnterTest.java
  4. java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java

Issue :
This doesn't seem to be a deadlock. When there is no sufficient delay after the mouse release(dragged mouse pointer release to drop the content), the frame is getting disposed even before the drop() method gets called. So it waits for the drop() method which will never happen as the frame has been already disposed and the test times out after some time.

Fix:
Waiting for the drop() method to get called before disposing the frame.

Testing:

  1. All the four tests are run 10 times per platform and got all pass
  2. All the four tests are run 10 times on Windows 11 and got all pass

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8274597: Some of the dnd tests time out and fail intermittently
  • JDK-8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8316/head:pull/8316
$ git checkout pull/8316

Update a local copy of the PR:
$ git checkout pull/8316
$ git pull https://git.openjdk.java.net/jdk pull/8316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8316

View PR using the GUI difftool:
$ git pr show -t 8316

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8316.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 20, 2022

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 20, 2022
@openjdk
Copy link

openjdk bot commented Apr 20, 2022

@manukumarvs The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label Apr 20, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 20, 2022

Webrevs

@manukumarvs
Copy link
Member Author

manukumarvs commented Apr 26, 2022

Any takers?

@mrserb
Copy link
Member

mrserb commented Apr 27, 2022

Why do these tests timeout? is it possible that we can get a deadlock there?

@manukumarvs
Copy link
Member Author

manukumarvs commented Apr 27, 2022

Why do these tests timeout? is it possible that we can get a deadlock there?

This doesn't seem to be a deadlock. When there is no sufficient delay after the mouse release(dragged mouse pointer release to drop the content), the frame is getting disposed even before the drop() method gets called. So it waits for the drop() method which will never happen as the frame has been already disposed and the test times out after some time. This can also be fixed by just adding a 100ms delay after mouse release.

mrserb
mrserb approved these changes Apr 28, 2022
@openjdk
Copy link

openjdk bot commented Apr 28, 2022

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274597: Some of the dnd tests time out and fail intermittently
8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

  • 269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
  • c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • d3606a3: 8285390: PPC64: Handle integral division overflow during parsing
  • f42631e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • b71e8c1: 8285711: riscv: RVC: Support disassembler show-bytes option
  • e406662: 8282711: Accelerate Math.signum function for AVX and AVX512 target.
  • 0a4a640: 8285301: C2: assert(!requires_atomic_access) failed: can't ensure atomicity
  • 40f19c0: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
  • 1e28fcb: 8155701: The compiler fails with an AssertionError: typeSig ERROR
  • 99388ef: 8283624: Create an automated regression test for RFE-4390885
  • ... and 123 more: https://git.openjdk.java.net/jdk/compare/0f81d8fcc3fb703760b1cddb01861ea5031023fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 28, 2022
@manukumarvs
Copy link
Member Author

manukumarvs commented Apr 29, 2022

/integrate

@openjdk openjdk bot added the sponsor label Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@manukumarvs
Your change (at version fae1d36) is now ready to be sponsored by a Committer.

…decoratedand moved to center,added captureScreen when test fails
@openjdk openjdk bot removed the sponsor label Apr 29, 2022
@manukumarvs
Copy link
Member Author

manukumarvs commented Apr 29, 2022

/integrate

@openjdk openjdk bot added the sponsor label Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@manukumarvs
Your change (at version f55b470) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@manukumarvs
Adding additional issue to issue list: 8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails.

@openjdk openjdk bot removed sponsor ready rfr labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@manukumarvs
Removing additional issue from issue list: 8030121.

@openjdk openjdk bot added the sponsor label Apr 29, 2022
@openjdk openjdk bot added ready rfr labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@manukumarvs The issue 8028998 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

@manukumarvs
Copy link
Member Author

manukumarvs commented Apr 29, 2022

/issue 8028998

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@manukumarvs
Adding additional issue to issue list: 8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed.

@akolarkunnu
Copy link
Contributor

akolarkunnu commented Apr 29, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 669ac61.
Since your change was applied there have been 133 commits pushed to the master branch:

  • 269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
  • c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • d3606a3: 8285390: PPC64: Handle integral division overflow during parsing
  • f42631e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • b71e8c1: 8285711: riscv: RVC: Support disassembler show-bytes option
  • e406662: 8282711: Accelerate Math.signum function for AVX and AVX512 target.
  • 0a4a640: 8285301: C2: assert(!requires_atomic_access) failed: can't ensure atomicity
  • 40f19c0: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
  • 1e28fcb: 8155701: The compiler fails with an AssertionError: typeSig ERROR
  • 99388ef: 8283624: Create an automated regression test for RFE-4390885
  • ... and 123 more: https://git.openjdk.java.net/jdk/compare/0f81d8fcc3fb703760b1cddb01861ea5031023fb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@akolarkunnu @manukumarvs Pushed as commit 669ac61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client integrated
4 participants