8274597: Some of the dnd tests time out and fail intermittently #8316

manukumarvs · 2022-04-20T13:03:48Z

These dnd tests fails with a time out intermittently in some machines(mostly Windows 11) which creates frequent noise in CI.

java/awt/dnd/AcceptDropMultipleTimes/AcceptDropMultipleTimes.java
java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java
java/awt/dnd/DropTargetEnterExitTest/ExtraDragEnterTest.java
java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java

Issue :
This doesn't seem to be a deadlock. When there is no sufficient delay after the mouse release(dragged mouse pointer release to drop the content), the frame is getting disposed even before the drop() method gets called. So it waits for the drop() method which will never happen as the frame has been already disposed and the test times out after some time.

Fix:
Waiting for the drop() method to get called before disposing the frame.

Testing:

All the four tests are run 10 times per platform and got all pass
All the four tests are run 10 times on Windows 11 and got all pass

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issues

JDK-8274597: Some of the dnd tests time out and fail intermittently
JDK-8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed

Reviewers

Sergey Bylokhov (@mrserb - Reviewer) ⚠️ Review applies to fae1d36

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8316/head:pull/8316
$ git checkout pull/8316

Update a local copy of the PR:
$ git checkout pull/8316
$ git pull https://git.openjdk.java.net/jdk pull/8316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8316

View PR using the GUI difftool:
$ git pr show -t 8316

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8316.diff

bridgekeeper · 2022-04-20T13:05:15Z

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-04-20T13:07:09Z

@manukumarvs The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-04-20T13:11:11Z

Webrevs

manukumarvs · 2022-04-26T07:07:02Z

Any takers?

mrserb · 2022-04-27T07:33:31Z

Why do these tests timeout? is it possible that we can get a deadlock there?

manukumarvs · 2022-04-27T11:00:18Z

Why do these tests timeout? is it possible that we can get a deadlock there?

This doesn't seem to be a deadlock. When there is no sufficient delay after the mouse release(dragged mouse pointer release to drop the content), the frame is getting disposed even before the drop() method gets called. So it waits for the drop() method which will never happen as the frame has been already disposed and the test times out after some time. This can also be fixed by just adding a 100ms delay after mouse release.

test/jdk/java/awt/regtesthelpers/Util.java

…sts waiting for drop() to get called, formatting changes, set the frame on top

openjdk · 2022-04-28T23:22:18Z

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274597: Some of the dnd tests time out and fail intermittently
8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
d3606a3: 8285390: PPC64: Handle integral division overflow during parsing
f42631e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
b71e8c1: 8285711: riscv: RVC: Support disassembler show-bytes option
e406662: 8282711: Accelerate Math.signum function for AVX and AVX512 target.
0a4a640: 8285301: C2: assert(!requires_atomic_access) failed: can't ensure atomicity
40f19c0: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
1e28fcb: 8155701: The compiler fails with an AssertionError: typeSig ERROR
99388ef: 8283624: Create an automated regression test for RFE-4390885
... and 123 more: https://git.openjdk.java.net/jdk/compare/0f81d8fcc3fb703760b1cddb01861ea5031023fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

manukumarvs · 2022-04-29T03:09:55Z

/integrate

openjdk · 2022-04-29T03:11:53Z

@manukumarvs
Your change (at version fae1d36) is now ready to be sponsored by a Committer.

…decoratedand moved to center,added captureScreen when test fails

manukumarvs · 2022-04-29T09:28:19Z

/integrate

openjdk · 2022-04-29T09:29:53Z

@manukumarvs
Your change (at version f55b470) is now ready to be sponsored by a Committer.

openjdk · 2022-04-29T10:10:06Z

@manukumarvs
Adding additional issue to issue list: 8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails.

openjdk · 2022-04-29T10:19:50Z

@manukumarvs
Removing additional issue from issue list: 8030121.

openjdk · 2022-04-29T10:22:41Z

@manukumarvs The issue 8028998 was not found in the JDK project - make sure you have entered it correctly.
As there were validation problems, no additional issues will be added to the list of solved issues.

manukumarvs · 2022-04-29T10:26:13Z

/issue 8028998

openjdk · 2022-04-29T10:26:54Z

@manukumarvs
Adding additional issue to issue list: 8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed.

akolarkunnu · 2022-04-29T10:33:07Z

/sponsor

openjdk · 2022-04-29T10:33:53Z

Going to push as commit 669ac61.
Since your change was applied there have been 133 commits pushed to the master branch:

269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
d3606a3: 8285390: PPC64: Handle integral division overflow during parsing
f42631e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
b71e8c1: 8285711: riscv: RVC: Support disassembler show-bytes option
e406662: 8282711: Accelerate Math.signum function for AVX and AVX512 target.
0a4a640: 8285301: C2: assert(!requires_atomic_access) failed: can't ensure atomicity
40f19c0: 8264666: Change implementation of safeAdd/safeMult in the LCMSImageLayout class
1e28fcb: 8155701: The compiler fails with an AssertionError: typeSig ERROR
99388ef: 8283624: Create an automated regression test for RFE-4390885
... and 123 more: https://git.openjdk.java.net/jdk/compare/0f81d8fcc3fb703760b1cddb01861ea5031023fb...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-04-29T10:34:08Z

@akolarkunnu @manukumarvs Pushed as commit 669ac61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8274597: Some of the dnd tests time out and fail intermittently

1a1657a

openjdk bot added the rfr label Apr 20, 2022

openjdk bot added the client label Apr 20, 2022

Added blank line at end of file

f008f89

prrace reviewed Apr 27, 2022

View changes

test/jdk/java/awt/regtesthelpers/Util.java Outdated Show resolved Hide resolved

manukumarvs added 2 commits Apr 28, 2022

Review comments fixed: Removed changes in Utils and made all the 4 te…

e0d6353

…sts waiting for drop() to get called, formatting changes, set the frame on top

Removed extra blank line added to Util, no changes required in Util

fae1d36

mrserb approved these changes Apr 28, 2022

View changes

openjdk bot added the ready label Apr 28, 2022

openjdk bot added the sponsor label Apr 29, 2022

Some more stabilization: f.getLocationOnScreen() in EDT,frame made un…

f55b470

…decoratedand moved to center,added captureScreen when test fails

openjdk bot removed the sponsor label Apr 29, 2022

openjdk bot added the sponsor label Apr 29, 2022

openjdk bot removed sponsor ready rfr labels Apr 29, 2022

openjdk bot added the sponsor label Apr 29, 2022

openjdk bot added ready rfr labels Apr 29, 2022

openjdk bot added the integrated label Apr 29, 2022

openjdk bot closed this Apr 29, 2022

openjdk bot removed ready rfr sponsor labels Apr 29, 2022

8274597: Some of the dnd tests time out and fail intermittently #8316

8274597: Some of the dnd tests time out and fail intermittently #8316

manukumarvs commented Apr 20, 2022 •

edited by openjdk[bot] bot

bridgekeeper bot commented Apr 20, 2022

openjdk bot commented Apr 20, 2022

mlbridge bot commented Apr 20, 2022 •

edited

manukumarvs commented Apr 26, 2022

mrserb commented Apr 27, 2022

manukumarvs commented Apr 27, 2022 •

edited

openjdk bot commented Apr 28, 2022 •

edited

manukumarvs commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

manukumarvs commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

manukumarvs commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

akolarkunnu commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

8274597: Some of the dnd tests time out and fail intermittently #8316

8274597: Some of the dnd tests time out and fail intermittently #8316

Conversation

manukumarvs commented Apr 20, 2022 • edited by openjdk[bot] bot

Progress

Issues

Reviewers

Reviewing

bridgekeeper bot commented Apr 20, 2022

openjdk bot commented Apr 20, 2022

mlbridge bot commented Apr 20, 2022 • edited

Webrevs

manukumarvs commented Apr 26, 2022

mrserb commented Apr 27, 2022

manukumarvs commented Apr 27, 2022 • edited

openjdk bot commented Apr 28, 2022 • edited

manukumarvs commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

manukumarvs commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

manukumarvs commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

akolarkunnu commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

openjdk bot commented Apr 29, 2022

manukumarvs commented Apr 20, 2022 •

edited by openjdk[bot] bot

mlbridge bot commented Apr 20, 2022 •

edited

manukumarvs commented Apr 27, 2022 •

edited

openjdk bot commented Apr 28, 2022 •

edited