-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8274597: Some of the dnd tests time out and fail intermittently #8316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mvs! A progress list of the required criteria for merging this PR into |
@manukumarvs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Any takers? |
Why do these tests timeout? is it possible that we can get a deadlock there? |
This doesn't seem to be a deadlock. When there is no sufficient delay after the mouse release(dragged mouse pointer release to drop the content), the frame is getting disposed even before the drop() method gets called. So it waits for the drop() method which will never happen as the frame has been already disposed and the test times out after some time. This can also be fixed by just adding a 100ms delay after mouse release. |
…sts waiting for drop() to get called, formatting changes, set the frame on top
@manukumarvs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 133 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@manukumarvs |
…decoratedand moved to center,added captureScreen when test fails
/integrate |
@manukumarvs |
@manukumarvs |
@manukumarvs |
@manukumarvs The issue |
/issue 8028998 |
@manukumarvs |
/sponsor |
Going to push as commit 669ac61.
Your commit was automatically rebased without conflicts. |
@akolarkunnu @manukumarvs Pushed as commit 669ac61. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
These dnd tests fails with a time out intermittently in some machines(mostly Windows 11) which creates frequent noise in CI.
Issue :
This doesn't seem to be a deadlock. When there is no sufficient delay after the mouse release(dragged mouse pointer release to drop the content), the frame is getting disposed even before the drop() method gets called. So it waits for the drop() method which will never happen as the frame has been already disposed and the test times out after some time.
Fix:
Waiting for the drop() method to get called before disposing the frame.
Testing:
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8316/head:pull/8316
$ git checkout pull/8316
Update a local copy of the PR:
$ git checkout pull/8316
$ git pull https://git.openjdk.java.net/jdk pull/8316/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8316
View PR using the GUI difftool:
$ git pr show -t 8316
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8316.diff