Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162 #833

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 23, 2020

I would like to have clean x86_32 test runs until JDK-8254162 arrives.

Testing:

  • Affected test on Linux x86_64 (still passes)
  • Affected test on Linux x86_32 (now ignored)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/833/head:pull/833
$ git checkout pull/833

…ms until JDK-8254162
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 23, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@shipilev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 23, 2020

/label core-libs

@openjdk openjdk bot added the core-libs label Oct 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@shipilev
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 23, 2020

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 26, 2020

@mcimadamore, please take a look? This seems to be the only thing that keeps x86_32 tier1 from being clean. I think you'd need to remove this test from the problem list with/after JDK-8254162 integration.

@shipilev shipilev mentioned this pull request Oct 26, 2020
3 of 3 tasks complete
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 27, 2020

Friendly reminder, please review, as it blocks #830

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255331: Problemlist java/foreign/TestMismatch.java on 32-bit platforms until JDK-8254162

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
  • 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
  • 7679650: 8231231: The printing result is different from the case instruction
  • f7c59c6: 8255231: Avoid upcalls when initializing the statSampler
  • dccfd2b: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method
  • d735f91: 8255040: Replace __sync_add_and_fetch with __atomic_add_fetch to avoid build errors with clang
  • bcdeeaa: 8199054: Test javax/swing/UIDefaults/8149879/InternalResourceBundle.java is unstable
  • dee31d0: 8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java
  • abdbbe3: 8254370: Update the classes in the java.awt.color package
  • 8ca59c9: 8255206: [macos] LicenseTest fails on macOS 11
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/63ce304ea4d816872b73d36abe42b6debec694a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 27, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Oct 27, 2020

Thanks, @mcimadamore!

/integrate

@openjdk openjdk bot closed this Oct 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@shipilev Since your change was applied there have been 44 commits pushed to the master branch:

  • cf56c7e: 8254980: ZGC: ZHeapIterator visits armed nmethods with -XX:-ClassUnloading
  • 18d9905: 8255342: Remove non-specified JVM checks on Classes with Record attributes
  • 7679650: 8231231: The printing result is different from the case instruction
  • f7c59c6: 8255231: Avoid upcalls when initializing the statSampler
  • dccfd2b: 8255389: ConcurrentHashTable::NoOp omits return in non-void return method
  • d735f91: 8255040: Replace __sync_add_and_fetch with __atomic_add_fetch to avoid build errors with clang
  • bcdeeaa: 8199054: Test javax/swing/UIDefaults/8149879/InternalResourceBundle.java is unstable
  • dee31d0: 8167355: [macos 10.12] Timeout in javax/swing/JTextArea/TextViewOOM/TextViewOOM.java
  • abdbbe3: 8254370: Update the classes in the java.awt.color package
  • 8ca59c9: 8255206: [macos] LicenseTest fails on macOS 11
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/63ce304ea4d816872b73d36abe42b6debec694a7...master

Your commit was automatically rebased without conflicts.

Pushed as commit 66a3917.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the shipilev:JDK-8255331-problemlist-mismatch branch Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants