8255338: CodeSections are never frozen

[cl4es]

CodeSections are never actually frozen, so code for freezing can be removed along with some assertions and guarantees.

A few other minor cleanups, too.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x32	Linux x64	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)		✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8255338: CodeSections are never frozen

Reviewers

• Nils Eliasson (@neliasso - Reviewer) ⚠️ Review applies to 37aca0c
• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/834/head:pull/834
$ git checkout pull/834

[bridgekeeper]

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cl4es The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dfb19e9)
• 00: Full (37aca0c)

[neliasso]

Looks good.

Remove the additional methods I sent, if you like.

[openjdk]

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255338: CodeSections are never frozen

Reviewed-by: neliasso, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
• 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
• 12daf2b: 8255340: [s390] build failure after JDK-8255208
• 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
• df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
• 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
• ac1748e: 8254670: SVE test uses linux-specific api
• 0e92053: 8254286: Wrong inference in switch expression with "null" arm
• 63ce304: 8249675: x86: frequency extraction from cpu brand string is incomplete
• e52156d: 8255067: Restore Copyright line in file modified by 8253191

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cl4es]

Looks good.

Thanks!

Remove the additional methods I sent, if you like.

Done.

[vnkozlov]

Good. It was part of original implementation of CodeBuffer. It was used for very short time in C1.

[cl4es]

@neliasso @vnkozlov - thank you for reviewing!

/integrate

[openjdk]

@cl4es Since your change was applied there have been 10 commits pushed to the master branch:

• cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
• 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
• 12daf2b: 8255340: [s390] build failure after JDK-8255208
• 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
• df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
• 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
• ac1748e: 8254670: SVE test uses linux-specific api
• 0e92053: 8254286: Wrong inference in switch expression with "null" arm
• 63ce304: 8249675: x86: frequency extraction from cpu brand string is incomplete
• e52156d: 8255067: Restore Copyright line in file modified by 8253191

Your commit was automatically rebased without conflicts.

Pushed as commit 185c8bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.