Skip to content

8255338: CodeSections are never frozen #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8255338: CodeSections are never frozen #834

wants to merge 2 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Oct 23, 2020 •
edited by openjdk bot
Loading

CodeSections are never actually frozen, so code for freezing can be removed along with some assertions and guarantees.

A few other minor cleanups, too.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/834/head:pull/834
$ git checkout pull/834

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2020

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@cl4es The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 23, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2020 •
edited
Loading

Webrevs

neliasso
neliasso approved these changes Oct 23, 2020
View reviewed changes
Copy link

@neliasso neliasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Remove the additional methods I sent, if you like.

@openjdk
Copy link

openjdk bot commented Oct 23, 2020 •
edited
Loading

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255338: CodeSections are never frozen

Reviewed-by: neliasso, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
  • 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm
  • 63ce304: 8249675: x86: frequency extraction from cpu brand string is incomplete
  • e52156d: 8255067: Restore Copyright line in file modified by 8253191

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 23, 2020
@cl4es
Copy link
Member Author

cl4es commented Oct 23, 2020

Looks good.

Thanks!

Remove the additional methods I sent, if you like.

Done.

vnkozlov
vnkozlov approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. It was part of original implementation of CodeBuffer. It was used for very short time in C1.

@cl4es
Copy link
Member Author

cl4es commented Oct 23, 2020

@neliasso @vnkozlov - thank you for reviewing!

/integrate

@openjdk openjdk bot closed this Oct 23, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2020
@openjdk
Copy link

openjdk bot commented Oct 23, 2020

@cl4es Since your change was applied there have been 10 commits pushed to the master branch:

  • cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
  • 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm
  • 63ce304: 8249675: x86: frequency extraction from cpu brand string is incomplete
  • e52156d: 8255067: Restore Copyright line in file modified by 8253191

Your commit was automatically rebased without conflicts.

Pushed as commit 185c8bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnkozlov vnkozlov vnkozlov approved these changes

@neliasso neliasso neliasso approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cl4es @vnkozlov @neliasso