Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285373: Create an automated test for JDK-4702233 #8342

Closed
wants to merge 2 commits into from

Conversation

srmandal
Copy link

@srmandal srmandal commented Apr 21, 2022

Create an automated test for JDK-4702233

Several new AccessibleRole and AccessibleRelation constants are needed in those classes in the java.accessibility package. These new contants codify additions made in the GNOME, Netscape, and UNO (StarOffice) accessibility APIs.
StarOffice 6.1 and GNOME accessibility require new role, state and relation
constants in the javax.accessibility package. The existing constants are
inadequate for providing accessibility to StarOffice and GNOME applications
as required by Section 508.

Solution

Define new constants in the javax.accessibility package.
AccessibleRelation
AccessibleRoles
AccessibleState
AccessibleAction
AccessibleContext

The test validates the public fields of the above AccessibleConstants.

This review is for migrating tests from a closed test suite to open.

Testing:
The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285373: Create an automated test for JDK-4702233

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8342/head:pull/8342
$ git checkout pull/8342

Update a local copy of the PR:
$ git checkout pull/8342
$ git pull https://git.openjdk.java.net/jdk pull/8342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8342

View PR using the GUI difftool:
$ git pr show -t 8342

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8342.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2022

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 21, 2022

@srmandal The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 21, 2022
@srmandal srmandal marked this pull request as ready for review April 22, 2022 06:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2022

Webrevs

@srmandal
Copy link
Author

Hi! Can someone please take a look at this PR and provide their valuable feedback ?

@srmandal
Copy link
Author

srmandal commented May 2, 2022

Hi! Can someone please take a look at this PR and provide their valuable feedback ?

@bridgekeeper
Copy link

bridgekeeper bot commented May 30, 2022

@srmandal This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@srmandal
Copy link
Author

srmandal commented Jun 1, 2022

Hi! Can someone please take a look at this PR and provide their valuable feedback ?

@openjdk
Copy link

openjdk bot commented Jun 2, 2022

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285373: Create an automated test for JDK-4702233

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 623 new commits pushed to the master branch:

  • b544b8b: 8276789: Support C++ lambda in ResourceHashtable::iterate
  • ba9ee8c: 8287748: Fix issues in java.lang.foreign package javadoc
  • deb0653: 8287337: SnippetUtils should throw exceptions if snippets not found
  • cbaeb00: 8287600: AA Ovals not rendered under metal
  • 2776ff3: 8276266: Clean up incorrect client-libs ProblemList.txt entries
  • 409157d: 8287125: [macos] Multiple jpackage tests fail/timeout on same host
  • b5a646e: 8287425: Remove unnecessary register push for MacroAssembler::check_klass_subtype_slow_path
  • 26048ea: 8287695: Use String.contains() instead of String.indexOf() in jdk.hotspot.agent
  • 37e1835: 8287746: ProblemList jni/nullCaller/NullCallerTest.java
  • 26d2426: 8287340: Refactor old code using StringTokenizer in locale related code
  • ... and 613 more: https://git.openjdk.java.net/jdk/compare/9a905ccc5e6411c3b68277b58e7c40b405e33afc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2022
@srmandal
Copy link
Author

srmandal commented Jun 3, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 3, 2022
@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@srmandal
Your change (at version 7715eb8) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Jun 3, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 3, 2022

Going to push as commit 6f526e1.
Since your change was applied there have been 635 commits pushed to the master branch:

  • a7e07fd: 8287102: ImageReaderSpi.canDecodeInput() for standard plugins should return false if a stream is too short
  • 7a0c8b1: 8286850: [macos] Add support for signing user provided app image
  • 0b35460: 8283694: Improve bit manipulation and boolean to integer conversion operations on x86_64
  • a0219da: 8287517: C2: assert(vlen_in_bytes == 64) failed: 2
  • ce5ae51: 8287637: Loom: Mismatched VirtualThread::state accessor
  • 59e9700: 8252717: Integrate/merge legacy standard doclet diagnostics and doclint
  • 28c112f: 8287685: [BACKOUT] JDK-8287384 Speed up jdk.test.lib.util.ForceGC
  • 34bb0a5: 8287734: Shenandoah: Consolidate marking closures
  • 33b9d77: 8287729: Loom: Check alternative implementation on x86_32
  • a75299c: 8287686: Add assertion to ensure that disarm value offset < 128
  • ... and 625 more: https://git.openjdk.java.net/jdk/compare/9a905ccc5e6411c3b68277b58e7c40b405e33afc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2022
@openjdk openjdk bot closed this Jun 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 3, 2022
@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@mrserb @srmandal Pushed as commit 6f526e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@srmandal srmandal deleted the 8285373 branch October 20, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants