-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285373: Create an automated test for JDK-4702233 #8342
Conversation
👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into |
Webrevs
|
Hi! Can someone please take a look at this PR and provide their valuable feedback ? |
Hi! Can someone please take a look at this PR and provide their valuable feedback ? |
@srmandal This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi! Can someone please take a look at this PR and provide their valuable feedback ? |
@srmandal This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 623 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 6f526e1.
Your commit was automatically rebased without conflicts. |
Create an automated test for JDK-4702233
Several new AccessibleRole and AccessibleRelation constants are needed in those classes in the java.accessibility package. These new contants codify additions made in the GNOME, Netscape, and UNO (StarOffice) accessibility APIs.
StarOffice 6.1 and GNOME accessibility require new role, state and relation
constants in the javax.accessibility package. The existing constants are
inadequate for providing accessibility to StarOffice and GNOME applications
as required by Section 508.
Solution
Define new constants in the javax.accessibility package.
AccessibleRelation
AccessibleRoles
AccessibleState
AccessibleAction
AccessibleContext
The test validates the public fields of the above AccessibleConstants.
This review is for migrating tests from a closed test suite to open.
Testing:
The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8342/head:pull/8342
$ git checkout pull/8342
Update a local copy of the PR:
$ git checkout pull/8342
$ git pull https://git.openjdk.java.net/jdk pull/8342/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8342
View PR using the GUI difftool:
$ git pr show -t 8342
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8342.diff