8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails

[azvegint]

Looks like this test was written based on assumption that SystemTray is supported on all platforms.

However on Linux it may not be true.

Availability of SystemTray is detected by getting owner of _NET_SYSTEM_TRAY selection:

jdk/src/java.desktop/unix/classes/sun/awt/X11/XSystemTrayPeer.java

Line 42 in 739769c

private final XMSelection selection = new XMSelection("_NET_SYSTEM_TRAY");

jdk/src/java.desktop/unix/classes/sun/awt/X11/XSystemTrayPeer.java

Lines 58 to 59 in 739769c

	long selection_owner = selection.getOwner(SCREEN);
	available = (selection_owner != XConstants.None);

As an example, SystemTray is not available on Wayland because of this.

So I modified the test:

• WIndows and macOS: expecting available SystemTray.
• Linux: check absence/presence of UnsupportedOperationException exception of SystemTray.getSystemTray() call based on SystemTray.isSupported() result.

Testing is green on all platforms.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8346/head:pull/8346
$ git checkout pull/8346

Update a local copy of the PR:
$ git checkout pull/8346
$ git pull https://git.openjdk.java.net/jdk pull/8346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8346

View PR using the GUI difftool:
$ git pr show -t 8346

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8346.diff

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fc2e3ee1)

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8193543: Regression automated test '/open/test/jdk/java/awt/TrayIcon/SystemTrayInstance/SystemTrayInstanceTest.java' fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• ce8db2c: 8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id()
• 4e252cf: 8285370: Fix typo in jdk.charsets
• d8025c9: 8285362: unify os::pause platform coding
• 82f0ac0: 8284995: G1: Do not mark through Closed Archive regions during concurrent mark
• 165f516: 8277056: Combining several C2 Print* flags asserts in xmlStream::pop_tag
• 139615b: 8285369: C2: emit reduction flag value in node and loop dumps
• 80219a4: 8284993: Replace System.exit call in swing tests with RuntimeException
• d84b9c5: 8285342: Zero build failure with clang due to values not handled in switch
• 58155a7: 8285386: java/util/HashMap/WhiteBoxResizeTest.java fails in tier7 after JDK-8186958
• f6e9ca0: 8283324: CLDRConverter run time increased by 3x
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/fa04d1f832ff201248f935939fa255988053a1d0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

/integrate

[openjdk]

Going to push as commit 08024d9.
Since your change was applied there have been 26 commits pushed to the master branch:

• a1efb95: 8129827: [TEST_BUG] Test java/awt/Robot/RobotWheelTest/RobotWheelTest.java fails
• 03cbb48: 8285445: cannot open file "NUL:"
• e9d604a: 8285431: Assertion in NativeGSSContext constructor
• 357b1b1: 8242440: use separate, destroyable JavaVM instances per libgraal compiler thread
• b10833b: 8285303: riscv: Incorrect register mask in call_native_base
• ce8db2c: 8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id()
• 4e252cf: 8285370: Fix typo in jdk.charsets
• d8025c9: 8285362: unify os::pause platform coding
• 82f0ac0: 8284995: G1: Do not mark through Closed Archive regions during concurrent mark
• 165f516: 8277056: Combining several C2 Print* flags asserts in xmlStream::pop_tag
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/fa04d1f832ff201248f935939fa255988053a1d0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint Pushed as commit 08024d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.