Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285431: Assertion in NativeGSSContext constructor #8355

Closed
wants to merge 1 commit into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Apr 22, 2022

Hi,

May I have the simple update reviewed.

In the NativeGSSContext constructor for imported context, the assert is use on the object field, instead of the input parameters. As in a constructor, 'this' object does not exist yet, this looks like an obvious issue. The fix is straightforward as well.

    NativeGSSContext(long pCtxt, GSSLibStub stub) throws GSSException {
-       assert(pContext != 0);
+       assert(pCtxt != 0);
        pContext = pCtxt;
        ...


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8285431: Assertion in NativeGSSContext constructor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8355/head:pull/8355
$ git checkout pull/8355

Update a local copy of the PR:
$ git checkout pull/8355
$ git pull https://git.openjdk.java.net/jdk pull/8355/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8355

View PR using the GUI difftool:
$ git pr show -t 8355

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8355.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2022

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 22, 2022
@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Apr 22, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2022

Webrevs

Copy link
Member

@djelinski djelinski left a comment

LGTM

@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285431: Assertion in NativeGSSContext constructor

Reviewed-by: djelinski, valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ce8db2c: 8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id()
  • 4e252cf: 8285370: Fix typo in jdk.charsets
  • d8025c9: 8285362: unify os::pause platform coding
  • 82f0ac0: 8284995: G1: Do not mark through Closed Archive regions during concurrent mark
  • 165f516: 8277056: Combining several C2 Print* flags asserts in xmlStream::pop_tag
  • 139615b: 8285369: C2: emit reduction flag value in node and loop dumps
  • 80219a4: 8284993: Replace System.exit call in swing tests with RuntimeException

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 22, 2022
@XueleiFan
Copy link
Member Author

XueleiFan commented Apr 23, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2022

Going to push as commit e9d604a.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 357b1b1: 8242440: use separate, destroyable JavaVM instances per libgraal compiler thread
  • b10833b: 8285303: riscv: Incorrect register mask in call_native_base
  • ce8db2c: 8285394: Compiler blackholes can be eliminated due to stale ciMethod::intrinsic_id()
  • 4e252cf: 8285370: Fix typo in jdk.charsets
  • d8025c9: 8285362: unify os::pause platform coding
  • 82f0ac0: 8284995: G1: Do not mark through Closed Archive regions during concurrent mark
  • 165f516: 8277056: Combining several C2 Print* flags asserts in xmlStream::pop_tag
  • 139615b: 8285369: C2: emit reduction flag value in node and loop dumps
  • 80219a4: 8284993: Replace System.exit call in swing tests with RuntimeException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 23, 2022
@openjdk openjdk bot closed this Apr 23, 2022
@openjdk openjdk bot removed ready rfr labels Apr 23, 2022
@openjdk
Copy link

openjdk bot commented Apr 23, 2022

@XueleiFan Pushed as commit e9d604a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8285431 branch Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
3 participants