Skip to content

JDK-8202790: DnD test DisposeFrameOnDragTest.java does not clean up #8370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Apr 22, 2022

Added a background to the test to prevent the file from dragging onto the desktop and creating an extra file.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8202790: DnD test DisposeFrameOnDragTest.java does not clean up

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8370/head:pull/8370
$ git checkout pull/8370

Update a local copy of the PR:
$ git checkout pull/8370
$ git pull https://git.openjdk.java.net/jdk pull/8370/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8370

View PR using the GUI difftool:
$ git pr show -t 8370

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8370.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2022

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 22, 2022
@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 22, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 22, 2022

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8202790: DnD test DisposeFrameOnDragTest.java does not clean up

Reviewed-by: serb, kizune, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 156 new commits pushed to the master branch:

  • 03bcf7b: 8283620: System.out does not use the encoding/charset specified in the Javadoc
  • 20a132d: 8284994: -Xdoclint:all returns warning for records, even when documented properly
  • a3b7881: 8284930: Re-examine FilterInputStream mark/reset
  • 97a0a29: 8283643: [AIX, testbug] MachCodeFramesInErrorFile test fails to find 'Native frames' text
  • 67755ed: 8284890: Support for Do not fragment IP socket options
  • a7b5157: 8282541: AArch64: Auto-vectorize Math.round API
  • 8de3c65: 8284951: Compile::flatten_alias_type asserts with "indeterminate pointers come only from unsafe ops"
  • 552e1b0: 8284779: Test java/util/logging/Logger/logrb/TestLogrbResourceBundle.java fails intermittently with vthreads wrapper
  • e333cd3: 8285611: Retrofit (Doc)Pretty with java.io.UncheckedIOException
  • 9478696: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • ... and 146 more: https://git.openjdk.java.net/jdk/compare/c7755b815d149425534aa4344c753591aa41b725...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @azuev-java, @prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 22, 2022
@prrace
Copy link
Contributor

prrace commented Apr 25, 2022

InputEvent.BUTTON1_MASK);

could be BUTTON1_DOWN_MASK since you are touching this already.

@prrace
Copy link
Contributor

prrace commented Apr 25, 2022

It looks OK. Would be nice to have a comment explaining that you are trying to prevent drop on to the desktop
which might accept this dragged text.
In fact you should explain this in the bug report eval too.

@alisenchung
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@alisenchung
Your change (at version 795d2a2) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented Apr 26, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 26, 2022

Going to push as commit 102a305.
Since your change was applied there have been 158 commits pushed to the master branch:

  • e3d714d: 8285677: ProblemList two tests from JDK-8285671 on macosx-x64
  • 975a060: 8284642: Unexpected behavior of -XX:MaxDirectMemorySize=0
  • 03bcf7b: 8283620: System.out does not use the encoding/charset specified in the Javadoc
  • 20a132d: 8284994: -Xdoclint:all returns warning for records, even when documented properly
  • a3b7881: 8284930: Re-examine FilterInputStream mark/reset
  • 97a0a29: 8283643: [AIX, testbug] MachCodeFramesInErrorFile test fails to find 'Native frames' text
  • 67755ed: 8284890: Support for Do not fragment IP socket options
  • a7b5157: 8282541: AArch64: Auto-vectorize Math.round API
  • 8de3c65: 8284951: Compile::flatten_alias_type asserts with "indeterminate pointers come only from unsafe ops"
  • 552e1b0: 8284779: Test java/util/logging/Logger/logrb/TestLogrbResourceBundle.java fails intermittently with vthreads wrapper
  • ... and 148 more: https://git.openjdk.java.net/jdk/compare/c7755b815d149425534aa4344c753591aa41b725...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 26, 2022
@openjdk openjdk bot closed this Apr 26, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@prrace @alisenchung Pushed as commit 102a305.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants