-
Notifications
You must be signed in to change notification settings - Fork 5.8k
JDK-8202790: DnD test DisposeFrameOnDragTest.java does not clean up #8370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
@alisenchung The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 156 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @azuev-java, @prrace) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
InputEvent.BUTTON1_MASK); could be BUTTON1_DOWN_MASK since you are touching this already. |
It looks OK. Would be nice to have a comment explaining that you are trying to prevent drop on to the desktop |
/integrate |
@alisenchung |
/sponsor |
Going to push as commit 102a305.
Your commit was automatically rebased without conflicts. |
@prrace @alisenchung Pushed as commit 102a305. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Added a background to the test to prevent the file from dragging onto the desktop and creating an extra file.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8370/head:pull/8370
$ git checkout pull/8370
Update a local copy of the PR:
$ git checkout pull/8370
$ git pull https://git.openjdk.java.net/jdk pull/8370/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8370
View PR using the GUI difftool:
$ git pr show -t 8370
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8370.diff