8284951: Compile::flatten_alias_type asserts with "indeterminate pointers come only from unsafe ops"

[TobiHartmann]

The Object.clone() intrinsic emits an arraycopy guarded by an array check. With StressReflectiveCode the arraycopy is not removed even if the source object is statically known to be a non-array instance. This triggers an assert in Compile::flatten_alias_type asserts because the (arraycopy) address type is an instance pointer with bottom offset.

The fix is to disable the assert when StressReflectiveCode is enabled.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8284951: Compile::flatten_alias_type asserts with "indeterminate pointers come only from unsafe ops"

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8381/head:pull/8381
$ git checkout pull/8381

Update a local copy of the PR:
$ git checkout pull/8381
$ git pull https://git.openjdk.java.net/jdk pull/8381/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8381

View PR using the GUI difftool:
$ git pr show -t 8381

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8381.diff

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d82d47bc)

[vnkozlov]

Good.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284951: Compile::flatten_alias_type asserts with "indeterminate pointers come only from unsafe ops"

Reviewed-by: kvn, roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• e333cd3: 8285611: Retrofit (Doc)Pretty with java.io.UncheckedIOException
• 9478696: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
• 00e9c96: 8285398: Cache the results of constraint checks
• 4bf2c18: 8285435: Show file and line in MacroAssembler::verify_oop for AArch64 and RISC-V platforms (Port from x86)
• d435d69: 8285614: Fix typo in java.lang.Float
• 3416bfa: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297
• 80a7f7b: 8267690: Revisit (Doc)Tree search implemented by throwing an exception
• 9b82708: 8284319: Test runtime/cds/appcds/TestParallelGCWithCDS.java fails in repo-loom
• fb60594: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double
• 1e79ded: 8284889: runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java#custom-cl-zgc timed out
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/c5aa75dd8126c70c74fc2b541d82ef664a4b5ffd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Thanks, Vladimir!

[rwestrel]

Looks good to me.

[TobiHartmann]

Thanks, Roland!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 8de3c65.
Since your change was applied there have been 17 commits pushed to the master branch:

• 552e1b0: 8284779: Test java/util/logging/Logger/logrb/TestLogrbResourceBundle.java fails intermittently with vthreads wrapper
• e333cd3: 8285611: Retrofit (Doc)Pretty with java.io.UncheckedIOException
• 9478696: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
• 00e9c96: 8285398: Cache the results of constraint checks
• 4bf2c18: 8285435: Show file and line in MacroAssembler::verify_oop for AArch64 and RISC-V platforms (Port from x86)
• d435d69: 8285614: Fix typo in java.lang.Float
• 3416bfa: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297
• 80a7f7b: 8267690: Revisit (Doc)Tree search implemented by throwing an exception
• 9b82708: 8284319: Test runtime/cds/appcds/TestParallelGCWithCDS.java fails in repo-loom
• fb60594: 8285477: Add a PRECISION public static field to j.l.Float and j.l.Double
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/c5aa75dd8126c70c74fc2b541d82ef664a4b5ffd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 8de3c65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.