Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8285614: Fix typo in java.lang.Float #8390

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Apr 25, 2022

Fix typo introduced in JDK-8261123.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8390/head:pull/8390
$ git checkout pull/8390

Update a local copy of the PR:
$ git checkout pull/8390
$ git pull https://git.openjdk.java.net/jdk pull/8390/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8390

View PR using the GUI difftool:
$ git pr show -t 8390

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8390.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 25, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2022

Webrevs

naotoj
naotoj approved these changes Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285614: Fix typo in java.lang.Float

Reviewed-by: naoto, lancea, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 3416bfa: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297
  • 80a7f7b: 8267690: Revisit (Doc)Tree search implemented by throwing an exception
  • 9b82708: 8284319: Test runtime/cds/appcds/TestParallelGCWithCDS.java fails in repo-loom

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 25, 2022
@jddarcy
Copy link
Member Author

jddarcy commented Apr 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 25, 2022

Going to push as commit d435d69.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3416bfa: 8283022: com/sun/crypto/provider/Cipher/AEAD/GCMBufferTest.java failing with -Xcomp after 8273297
  • 80a7f7b: 8267690: Revisit (Doc)Tree search implemented by throwing an exception
  • 9b82708: 8284319: Test runtime/cds/appcds/TestParallelGCWithCDS.java fails in repo-loom

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 25, 2022
@openjdk openjdk bot closed this Apr 25, 2022
@openjdk openjdk bot removed ready rfr labels Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@jddarcy Pushed as commit d435d69.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants