Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285612 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java #8391

Closed
wants to merge 3 commits into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Apr 25, 2022

  1. Removed yesno to eliminate parserException
  2. Added code to fit into manual framework so that timeout, pass & fail is handled.
  3. Added code to mark the test as pass if printer service is not available
  4. Added code to handle pressing or clicking of 'Cancel' button.

@shurymury
@aivanov-jdk


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8391/head:pull/8391
$ git checkout pull/8391

Update a local copy of the PR:
$ git checkout pull/8391
$ git pull https://git.openjdk.java.net/jdk pull/8391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8391

View PR using the GUI difftool:
$ git pr show -t 8391

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8391.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2022

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 25, 2022
@openjdk
Copy link

openjdk bot commented Apr 25, 2022

@lawrence-andrew The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 25, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 9, 2022

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 193 new commits pushed to the master branch:

  • 6a7c023: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • 40470d8: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out
  • 837928b: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  • 397d095: 8285743: Ensure each IntegerPolynomial object is only created once
  • 29ccb8f: 8285914: AppCDS crash when using shared archive with old class file
  • fe6e0c0: 8286371: Avoid use of deprecated str[n]icmp
  • 97a9835: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]
  • 034f20f: 8212136: Remove finalizer implementation in SSLSocketImpl
  • 36e4df9: 8285516: clearPassword should be called in a finally try block
  • b849efd: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • ... and 183 more: https://git.openjdk.java.net/jdk/compare/80a7f7becfc362fc3918a2442aea912533373c26...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 9, 2022
@lawrence-andrew
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 9, 2022
@openjdk
Copy link

openjdk bot commented May 9, 2022

@lawrence-andrew
Your change (at version eb44f66) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented May 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 11, 2022

Going to push as commit 57a7670.
Since your change was applied there have been 250 commits pushed to the master branch:

  • 44a60ce: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • ccbe8fa: 8282772: JButton text set as HTML content has unwanted padding
  • 1586bf8: 8286401: Address possibly lossy conversions in Microbenchmarks
  • 1c50ea3: 8282607: runtime/ErrorHandling/MachCodeFramesInErrorFile.java failed with "RuntimeException: 0 < 2"
  • fcf49f4: 8286441: Remove mode parameter from jdk.internal.perf.Perf.attach()
  • 46a775a: 8286540: Build failure caused by missing DefaultPollerProvider implementation on AIX
  • 4ad8cfa: 8286002: Add support for intel syntax to capstone hsdis
  • cec23b1: 8286556: Remove EagerInitialization develop option
  • 89de756: 8286387: Remove unused FreeListAllocator::reduce_free_list
  • ae695d6: 8286476: x86_32: Fix crashes with non-preview mode after JDK-8284161 (Virtual Threads)
  • ... and 240 more: https://git.openjdk.java.net/jdk/compare/80a7f7becfc362fc3918a2442aea912533373c26...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 11, 2022
@openjdk openjdk bot closed this May 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 11, 2022
@openjdk
Copy link

openjdk bot commented May 11, 2022

@prrace @lawrence-andrew Pushed as commit 57a7670.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants