Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Apr 26, 2022

This was caused by incorporating CLDR v39, which switched the Norwegian locale inheritance from no -> nb to nb ->no and moved the resources from nb to no, which now contradicts Java's locale fallback. Explicitly inheriting no from nb will fix the issue.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8282227: Locale information for nb is not working properly

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8394/head:pull/8394
$ git checkout pull/8394

Update a local copy of the PR:
$ git checkout pull/8394
$ git pull https://git.openjdk.java.net/jdk pull/8394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8394

View PR using the GUI difftool:
$ git pr show -t 8394

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8394.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Apr 26, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2022

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282227: Locale information for nb is not working properly

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 167 new commits pushed to the master branch:

  • 67dd8a8: 8285686: Upgrade to FreeType 2.12.0
  • 64225e1: 8285919: Remove debug printout from JDK-8285093
  • df4d5cf: 8285802: AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • 694556e: 8225433: Clarify behavior of PKIXParameters.setRevocationEnabled when PKIXRevocationChecker is used
  • e98ac23: 8285793: C2: optimization of mask checks in counted loops fail in the presence of cast nodes
  • 669ac61: 8274597: Some of the dnd tests time out and fail intermittently
  • 269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
  • c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • d3606a3: 8285390: PPC64: Handle integral division overflow during parsing
  • f42631e: 8285523: Improve test java/io/FileOutputStream/OpenNUL.java
  • ... and 157 more: https://git.openjdk.java.net/jdk/compare/13fb1eed52f1a9152242119969a9d4a0c0627513...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 29, 2022
@naotoj
Copy link
Member Author

naotoj commented Apr 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

Going to push as commit 3d07b3c.
Since your change was applied there have been 168 commits pushed to the master branch:

  • cfe67af: 8285938: ProblemList jdk/jshell/HighlightUITest.java on linux-x64
  • 67dd8a8: 8285686: Upgrade to FreeType 2.12.0
  • 64225e1: 8285919: Remove debug printout from JDK-8285093
  • df4d5cf: 8285802: AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • 694556e: 8225433: Clarify behavior of PKIXParameters.setRevocationEnabled when PKIXRevocationChecker is used
  • e98ac23: 8285793: C2: optimization of mask checks in counted loops fail in the presence of cast nodes
  • 669ac61: 8274597: Some of the dnd tests time out and fail intermittently
  • 269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
  • c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • d3606a3: 8285390: PPC64: Handle integral division overflow during parsing
  • ... and 158 more: https://git.openjdk.java.net/jdk/compare/13fb1eed52f1a9152242119969a9d4a0c0627513...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 29, 2022
@openjdk openjdk bot closed this Apr 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@naotoj Pushed as commit 3d07b3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@eivinhb
Copy link

eivinhb commented Sep 30, 2022

Will this fix make its way back to java 17?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants