Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285617 : Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test #8395

Closed
wants to merge 1 commit into from

Conversation

lawrence-andrew
Copy link
Contributor

@lawrence-andrew lawrence-andrew commented Apr 26, 2022

  1. Removed yesno since test was failing with parser error due to @run main/manual=yesno
  2. User can't decide whether it as pass or fail after looking into the printout so add the PassFailJFrame support

@shurymury
@aivanov-jdk


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8395/head:pull/8395
$ git checkout pull/8395

Update a local copy of the PR:
$ git checkout pull/8395
$ git pull https://git.openjdk.java.net/jdk pull/8395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8395

View PR using the GUI difftool:
$ git pr show -t 8395

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8395.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 26, 2022

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@lawrence-andrew The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 26, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 26, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test

Reviewed-by: prr, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 16a8ebb: 8285675: Temporary fix for arm32 SafeFetch
  • 72f82dd: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE
  • 4714fdc: 8285279: ArgumentsTest.set_numeric_flag_double_vm fails on some locales (again)
  • cc89f1b: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac
  • d3ea4b7: 8283435: AArch64: [vectorapi] Optimize SVE lane/withLane operations for 64/128-bit vector sizes
  • 16ebe40: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • e574cc0: 8196367: java/awt/List/SingleModeDeselect/SingleModeDeselect.java times out
  • 14e7d91: 8285404: RSA signature verification should reject non-DER OCTET STRING
  • 110edd9: 8284965: closed test sun/java2d/OpenGL/XORPaint.java is unstable
  • dbcf389: 8198666: Many java/awt/Modal/OnTop/ test fails on mac
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/4bf2c18d6c2b4e54c27fb557e679b9c24e09c0e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @prsadhuk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 26, 2022
@lawrence-andrew
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 26, 2022
@openjdk
Copy link

openjdk bot commented Apr 26, 2022

@lawrence-andrew
Your change (at version a5ab746) is now ready to be sponsored by a Committer.

@prsadhuk
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 27, 2022

Going to push as commit e7c3b9d.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 16a8ebb: 8285675: Temporary fix for arm32 SafeFetch
  • 72f82dd: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE
  • 4714fdc: 8285279: ArgumentsTest.set_numeric_flag_double_vm fails on some locales (again)
  • cc89f1b: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac
  • d3ea4b7: 8283435: AArch64: [vectorapi] Optimize SVE lane/withLane operations for 64/128-bit vector sizes
  • 16ebe40: 8251177: [macosx] The text "big" is truncated in JTabbedPane
  • e574cc0: 8196367: java/awt/List/SingleModeDeselect/SingleModeDeselect.java times out
  • 14e7d91: 8285404: RSA signature verification should reject non-DER OCTET STRING
  • 110edd9: 8284965: closed test sun/java2d/OpenGL/XORPaint.java is unstable
  • dbcf389: 8198666: Many java/awt/Modal/OnTop/ test fails on mac
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/4bf2c18d6c2b4e54c27fb557e679b9c24e09c0e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 27, 2022
@openjdk openjdk bot closed this Apr 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@prsadhuk @lawrence-andrew Pushed as commit e7c3b9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lawrence-andrew lawrence-andrew deleted the JDK-8285617 branch April 27, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants