Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255242: Bidi.requiresBidi has misleading exception message #841

Closed
wants to merge 1 commit into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Oct 23, 2020

Hi,

Please review this small exception message fix.

Naoto


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

  • JDK-8255242: Bidi.requiresBidi has misleading exception message

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/841/head:pull/841
$ git checkout pull/841

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 23, 2020

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@naotoj naotoj marked this pull request as ready for review Oct 23, 2020
@openjdk openjdk bot added the rfr label Oct 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 23, 2020

Webrevs

Loading

Copy link
Member

@bchristi-git bchristi-git left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255242: Bidi.requiresBidi has misleading exception message

Reviewed-by: bchristi

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
  • 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • 9007bc2: 8255129: [PPC64, s390] Check vector_size_supported and add VectorReinterpret node
  • df79257: 8255274: [PPC64, s390] wrong StringLatin1.indexOf version matched
  • 55a0cad: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • ac1748e: 8254670: SVE test uses linux-specific api
  • 0e92053: 8254286: Wrong inference in switch expression with "null" arm
  • 63ce304: 8249675: x86: frequency extraction from cpu brand string is incomplete
  • e52156d: 8255067: Restore Copyright line in file modified by 8253191
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/ff5f2265d20d2a462691b332eb5dfcca91a22fe4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 23, 2020
@naotoj
Copy link
Member Author

@naotoj naotoj commented Oct 25, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2020

@naotoj Since your change was applied there have been 26 commits pushed to the master branch:

  • 60d0142: 8255379: ProblemList compiler/loopstripmining/BackedgeNodeWithOutOfLoopControl.java
  • 1a94ebc: 8254112: javax/swing/plaf/basic/BasicComboPopup/JComboBoxPopupLocation/JComboBoxPopupLocation.java fails on windows
  • 69b0172: 8199074: Test javax/swing/DataTransfer/8059739/bug8059739.java is unstable
  • 6545e19: 8255078: sun/net/ftp/imp/FtpClient$MLSxParser uses wrong datetime format
  • 3f6abd2: 8255330: gtest/MetaspaceGtests.java fail on 32-bit platforms
  • cf821b0: 8232024: Don't pollute log output with multiple errors of the same type
  • 185c8bc: 8255338: CodeSections are never frozen
  • cc86113: 8255271: Avoid generating duplicate interpreter entries for subword types
  • 5ec1b80: 8255287: aarch64: fix SVE patterns for vector shift count
  • 12daf2b: 8255340: [s390] build failure after JDK-8255208
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/ff5f2265d20d2a462691b332eb5dfcca91a22fe4...master

Your commit was automatically rebased without conflicts.

Pushed as commit 57d903b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@naotoj naotoj deleted the JDK-8255242 branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants