-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8238373: Punctuation should be same in jlink help usage on Japanese language #8417
Conversation
👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into |
@tkiriyama The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Nit: please modify the copyright years for javap
properties files, as you modified the base (javap.properties
) file.
@tkiriyama This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 177 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I’m sorry for the late reply. |
I think it's ready for you to integrate. I can sponsor your changes. |
/integrate |
@tkiriyama |
/sponsor |
Going to push as commit c4bd449.
Your commit was automatically rebased without conflicts. |
@naotoj @tkiriyama Pushed as commit c4bd449. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
When showing help for the jlink command in a Japanese locale, delimiters of option's aliases are a mixture of "," and \u3001. Delimiter should be unified to ",".
As the same, there is a inconsistency of delimiters in the jar command help in a Japanese locale, and "," should be used.
Similarly, the javap command help uses space as delimiters other than the module option in all locales. This inconsistency should also be corrected.
Would you please review this fix?
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8417/head:pull/8417
$ git checkout pull/8417
Update a local copy of the PR:
$ git checkout pull/8417
$ git pull https://git.openjdk.java.net/jdk pull/8417/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8417
View PR using the GUI difftool:
$ git pr show -t 8417
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8417.diff