Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238373: Punctuation should be same in jlink help usage on Japanese language #8417

Closed
wants to merge 2 commits into from

Conversation

tkiriyama
Copy link
Contributor

@tkiriyama tkiriyama commented Apr 27, 2022

When showing help for the jlink command in a Japanese locale, delimiters of option's aliases are a mixture of "," and \u3001. Delimiter should be unified to ",".
As the same, there is a inconsistency of delimiters in the jar command help in a Japanese locale, and "," should be used.
Similarly, the javap command help uses space as delimiters other than the module option in all locales. This inconsistency should also be corrected.

Would you please review this fix?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8238373: Punctuation should be same in jlink help usage on Japanese language

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8417/head:pull/8417
$ git checkout pull/8417

Update a local copy of the PR:
$ git checkout pull/8417
$ git pull https://git.openjdk.java.net/jdk pull/8417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8417

View PR using the GUI difftool:
$ git pr show -t 8417

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8417.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2022

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@tkiriyama The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Apr 27, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2022

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Nit: please modify the copyright years for javap properties files, as you modified the base (javap.properties) file.

@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@tkiriyama This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8238373: Punctuation should be same in jlink help usage on Japanese language

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 177 new commits pushed to the master branch:

  • 9a3cb93: 8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails
  • ace4230: 8261650: Add a comment with details for MTLVC_MAX_INDEX
  • 2939553: 8282351: jpackage does not work if class file has $$ in the name on windows
  • 61450bb: 8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory
  • c28a636: 8286442: ProblemList compiler/c2/irTests/TestSkeletonPredicates.java in -Xcomp mode
  • 54e3308: 8286348: incorrect use of @serial
  • b0d2b0a: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
  • 902b1dd: 8284686: Interval of < 1 ms disables ExecutionSample events
  • 02e5fc0: 8286435: JDK-8284316 caused validate-source to fail in Tier1
  • 6a7c023: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • ... and 167 more: https://git.openjdk.java.net/jdk/compare/4714fdcd6a1615b9d357dab0116a579c1cd5bfb5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 27, 2022
@tkiriyama
Copy link
Contributor Author

Looks fine to me. Nit: please modify the copyright years for javap properties files, as you modified the base (javap.properties) file.

I’m sorry for the late reply.
Thank you for your advice. I modified the copyright years for all files.

@naotoj
Copy link
Member

naotoj commented May 9, 2022

I think it's ready for you to integrate. I can sponsor your changes.

@tkiriyama
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@tkiriyama
Your change (at version c881ec7) is now ready to be sponsored by a Committer.

@naotoj
Copy link
Member

naotoj commented May 10, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 10, 2022

Going to push as commit c4bd449.
Since your change was applied there have been 185 commits pushed to the master branch:

  • 3fa1c40: 8286298: Remove unused methods in sun.invoke.util.VerifyType
  • 3462190: 8286163: micro-optimize Instant.plusSeconds
  • 60a91d1: 8286285: G1: Rank issues with ParGCRareEvent_lock and Threads_lock
  • d478958: 8286179: Node::find(int) should not traverse from new to old nodes
  • de8f4d0: 8286191: misc tests fail due to JDK-8285987
  • bf0dc4f: 8286367: riscv: riscv port is broken after JDK-8284161
  • 4fd79a6: 8285730: unify _WIN32_WINNT settings
  • bd6026c: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell.
  • 9a3cb93: 8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails
  • ace4230: 8261650: Add a comment with details for MTLVC_MAX_INDEX
  • ... and 175 more: https://git.openjdk.java.net/jdk/compare/4714fdcd6a1615b9d357dab0116a579c1cd5bfb5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 10, 2022
@openjdk openjdk bot closed this May 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 10, 2022
@openjdk
Copy link

openjdk bot commented May 10, 2022

@naotoj @tkiriyama Pushed as commit c4bd449.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants