8285690: CloneableReference subtest should not throw CloneNotSupportedException

[kimbarrett]

Please review this fix to test/jdk/java/lang/ref/ReferenceClone.java. It was
passing if CloneableReference::clone were to throw CloneNotSupportedException.
That should be a failure.

Testing:
Locally (linux-x64) verified test still passes. Temporarily changed
CloneableReference::clone to throw and verified the expected failure gets
reported, unlike before.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8285690: CloneableReference subtest should not throw CloneNotSupportedException

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8418/head:pull/8418
$ git checkout pull/8418

Update a local copy of the PR:
$ git checkout pull/8418
$ git pull https://git.openjdk.java.net/jdk pull/8418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8418

View PR using the GUI difftool:
$ git pr show -t 8418

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8418.diff

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8f863628)
• 00: Full (47043626)

[RogerRiggs]

LGTM

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285690: CloneableReference subtest should not throw CloneNotSupportedException

Reviewed-by: rriggs, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 4919525: 8285440: Typo in Collections.addAll method javadoc
• e7c3b9d: 8285617: Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test
• 16a8ebb: 8285675: Temporary fix for arm32 SafeFetch

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlchung]

Alternatively, it could simply let CNSE propagate.

CloneableReference ref = new CloneableReference(o);
ref.clone();

test() and main will need to declare this checked exception.

[kimbarrett]

That was my initial thought, but it doesn't work - CNSE is a checked exception so must be handled.

[mlchung]

test() and main will need to declare this checked exception.

diff --git a/test/jdk/java/lang/ref/ReferenceClone.java b/test/jdk/java/lang/ref/ReferenceClone.java
index bd1ead81bec..2f9386b81e4 100644
--- a/test/jdk/java/lang/ref/ReferenceClone.java
+++ b/test/jdk/java/lang/ref/ReferenceClone.java
@@ -31,12 +31,12 @@ import java.lang.ref.*;
 
 public class ReferenceClone {
     private static final ReferenceQueue<Object> QUEUE = new ReferenceQueue<>();
-    public static void main(String... args) {
+    public static void main(String... args) throws Exception {
         ReferenceClone refClone = new ReferenceClone();
         refClone.test();
     }
 
-    public void test() {
+    public void test() throws CloneNotSupportedException {
         // test Reference::clone that throws CNSE
         Object o = new Object();
         assertCloneNotSupported(new SoftRef(o));
@@ -45,9 +45,7 @@ public class ReferenceClone {
 
         // Reference subclass may override the clone method
         CloneableReference ref = new CloneableReference(o);
-        try {
             ref.clone();
-        } catch (CloneNotSupportedException e) {}
     }
 
     private void assertCloneNotSupported(CloneableRef ref) {
     ```

[kimbarrett]

Yes, that would work. But I'd rather keep the code for that subtest close together, i.e. as currently written.

[kimbarrett]

Thanks for reviews @RogerRiggs and @mlchung

[kimbarrett]

/integrate

[openjdk]

Going to push as commit 2d8d140.
Since your change was applied there have been 28 commits pushed to the master branch:

• ea83b44: 8280510: AArch64: Vectorize operations with loop induction variable
• 36bf6fb: 8285728: Alpine Linux build fails with busybox tar
• 091637c: 8285630: Fix a configure error in RISC-V cross build
• ccf0e8b: 8285755: JDK-8285093 changed the default for --with-output-sync
• d7514b0: 8285595: Assert frame anchor doesn't change in safepoints/handshakes
• 5629c75: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
• 85f8d14: 8283994: Make Xerces DatatypeException stackless
• 4f2e4c7: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
• 4795165: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
• c1173c2: 8285493: ECC calculation error
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/72f82dd723bf1c048d140238154580db434706e2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit 2d8d140.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.