8285755: JDK-8285093 changed the default for --with-output-sync

[erikj79]

The make option '--output-sync recurse' can be useful in certain situations, especially when dealing with very verbose output from makefiles and you want to parse them after the fact. However, when running make interactively on the command line, it certainly gets in the way, as output from each sub make call is buffered until that make process terminates.

In JDK-8285093, the configure logic for this configuration was changed and, probably by mistake, the default was changes to default "recurse" if available in the supplied GNU make. This is a regression for most users of the build system and needs to be changed back.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8285755: JDK-8285093 changed the default for --with-output-sync

Reviewers

• Mikael Vidstedt (@vidmik - Reviewer)
• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8431/head:pull/8431
$ git checkout pull/8431

Update a local copy of the PR:
$ git checkout pull/8431
$ git pull https://git.openjdk.java.net/jdk pull/8431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8431

View PR using the GUI difftool:
$ git pr show -t 8431

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8431.diff

[bridgekeeper]

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@erikj79 The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (eb64bdee)

[openjdk]

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285755: JDK-8285093 changed the default for --with-output-sync

Reviewed-by: mikael, mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 5629c75: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
• 85f8d14: 8283994: Make Xerces DatatypeException stackless
• 4f2e4c7: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
• 4795165: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
• c1173c2: 8285493: ECC calculation error
• 89fd6d3: 8284910: Buffer clean in PasswordCallback
• cf1b00a: 8285683: Missing @ since 11 in java.security.spec.MGF1ParameterSpec fields
• 3312d8c: 8285756: clean up use of bad arguments for @clean in langtools tests
• 5c09349: 8285032: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected"
• 1f868f1: 8285658: Fix two typos in the spec of j.u.random.RandomGenerator
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/16ebe40a1bcd1fe43126fe1dca27bb64cb12de16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mcimadamore]

Looks good!

[erikj79]

/integrate

[openjdk]

Going to push as commit ccf0e8b.
Since your change was applied there have been 28 commits pushed to the master branch:

• d7514b0: 8285595: Assert frame anchor doesn't change in safepoints/handshakes
• 5629c75: 8284848: C2: Compiler blackhole arguments should be treated as globally escaping
• 85f8d14: 8283994: Make Xerces DatatypeException stackless
• 4f2e4c7: 8178969: [TESTBUG] Wrong reporting of gc/g1/humongousObjects/TestHeapCounters test.
• 4795165: 8285696: AlgorithmConstraints:permits not throwing IllegalArgumentException when 'alg' is null
• c1173c2: 8285493: ECC calculation error
• 89fd6d3: 8284910: Buffer clean in PasswordCallback
• cf1b00a: 8285683: Missing @ since 11 in java.security.spec.MGF1ParameterSpec fields
• 3312d8c: 8285756: clean up use of bad arguments for @clean in langtools tests
• 5c09349: 8285032: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy008/ fails with "eventSet.suspendPolicy() != policyExpected"
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/16ebe40a1bcd1fe43126fe1dca27bb64cb12de16...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 Pushed as commit ccf0e8b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.