Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284613: invalid use of @serial tag #8432

Closed
wants to merge 1 commit into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Apr 27, 2022

Removed serial tag in method documentation


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8432/head:pull/8432
$ git checkout pull/8432

Update a local copy of the PR:
$ git checkout pull/8432
$ git pull https://git.openjdk.java.net/jdk pull/8432/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8432

View PR using the GUI difftool:
$ git pr show -t 8432

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8432.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2022

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 27, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2022

Webrevs

@openjdk openjdk bot added csr Pull request needs approved CSR before integration and removed csr Pull request needs approved CSR before integration labels Apr 27, 2022
@prrace
Copy link
Contributor

prrace commented May 4, 2022

doc-only - my review should be enough

@openjdk
Copy link

openjdk bot commented May 4, 2022

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284613: invalid use of @serial tag

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 317 new commits pushed to the master branch:

  • 9583e36: 8284161: Implementation of Virtual Threads (Preview)
  • 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage
  • d8f9686: 8286342: ProblemList compiler/c2/irTests/TestEnumFinalFold.java
  • bb52ea6: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 5a1d8f7: 8285295: Need better testing for IdentityHashMap
  • 080f3c5: 8286190: Add test to verify constant folding for Enum fields
  • 1277f5d: 8286154: Fix 3rd party notices in test files
  • 2dd4dfd: 8286291: G1: Remove unused segment allocator printouts
  • b9f4370: 8286189: G1: Change "wasted" memory to "unused" memory in reporting
  • c6eab98: 8285378: Remove unnecessary nop for C1 exception and deopt handler
  • ... and 307 more: https://git.openjdk.java.net/jdk/compare/c7755b815d149425534aa4344c753591aa41b725...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2022
@alisenchung
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 8, 2022
@openjdk
Copy link

openjdk bot commented May 8, 2022

@alisenchung
Your change (at version aeabbb3) is now ready to be sponsored by a Committer.

@prrace
Copy link
Contributor

prrace commented May 8, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 8, 2022

Going to push as commit cdd1b0d.
Since your change was applied there have been 317 commits pushed to the master branch:

  • 9583e36: 8284161: Implementation of Virtual Threads (Preview)
  • 5212535: 8282218: C1: Missing side effects of dynamic class loading during constant linkage
  • d8f9686: 8286342: ProblemList compiler/c2/irTests/TestEnumFinalFold.java
  • bb52ea6: 8286263: compiler/c1/TestPinnedIntrinsics.java failed with "RuntimeException: testCurrentTimeMillis failed with -3"
  • 5a1d8f7: 8285295: Need better testing for IdentityHashMap
  • 080f3c5: 8286190: Add test to verify constant folding for Enum fields
  • 1277f5d: 8286154: Fix 3rd party notices in test files
  • 2dd4dfd: 8286291: G1: Remove unused segment allocator printouts
  • b9f4370: 8286189: G1: Change "wasted" memory to "unused" memory in reporting
  • c6eab98: 8285378: Remove unnecessary nop for C1 exception and deopt handler
  • ... and 307 more: https://git.openjdk.java.net/jdk/compare/c7755b815d149425534aa4344c753591aa41b725...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2022
@openjdk openjdk bot closed this May 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 8, 2022
@openjdk
Copy link

openjdk bot commented May 8, 2022

@prrace @alisenchung Pushed as commit cdd1b0d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge mlbridge bot mentioned this pull request May 21, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants