Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285745: Re-examine PushbackInputStream mark/reset #8433

Closed

Conversation

bplb
Copy link
Member

@bplb bplb commented Apr 27, 2022

Please review this request to remove the synchronized keyword from the mark(int) and reset() methods of java.io.PushbackInputStream.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)
  • Change requires a CSR request to be approved

Issues

  • JDK-8285745: Re-examine PushbackInputStream mark/reset
  • JDK-8285759: Re-examine PushbackInputStream mark/reset (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8433/head:pull/8433
$ git checkout pull/8433

Update a local copy of the PR:
$ git checkout pull/8433
$ git pull https://git.openjdk.java.net/jdk pull/8433/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8433

View PR using the GUI difftool:
$ git pr show -t 8433

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8433.diff

@bplb
Copy link
Member Author

bplb commented Apr 27, 2022

Please see also #8309.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2022

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr csr labels Apr 27, 2022
@openjdk
Copy link

openjdk bot commented Apr 27, 2022

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 27, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 27, 2022

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Looks fine to me.
Given that mark() currently is a no-op and reset() throws an exception, the synchronized wouldn't be doing anything when it comes to calls on an exact instance of PushbackInputStream.
Calls on subclasses of PushbackInputStream which did support mark/reset, would be overriding this method already and handling any synchronization themselves.

@openjdk openjdk bot removed the csr label May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285745: Re-examine PushbackInputStream mark/reset

Reviewed-by: jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

  • 41de506: 8285507: revert fix for JDK-8282704 now that JDK-8282952 is fixed
  • 7a95a40: 8285970: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java still fails after JDK-8285011
  • 4a79270: 8284632: runtime/Thread/StopAtExit.java possibly leaking memory again
  • cfcba1f: 8285827: Describe the keystore.pkcs12.legacy system property in the java.security file
  • 7020595: 8284435: Add dedicated filler objects for known dead Java heap areas
  • 1f9f873: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled
  • cf81f6c: 8285712: LogMessageBuffer doesn't check vsnprintf return value
  • 9795ef5: 8285851: Cleanup C2AtomicParseAccess::needs_pinning()
  • 3eb661b: 8285890: Fix some @param tags
  • d9541c5: 8276202: LogFileOutput.invalid_file_vm asserts when being executed from a read only working directory
  • ... and 50 more: https://git.openjdk.java.net/jdk/compare/1f868f1d091602cc462ee0fe5fa613a3638a5f1c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 2, 2022
@bplb
Copy link
Member Author

bplb commented May 2, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2022

Going to push as commit 9d8c3bf.
Since your change was applied there have been 60 commits pushed to the master branch:

  • 41de506: 8285507: revert fix for JDK-8282704 now that JDK-8282952 is fixed
  • 7a95a40: 8285970: gc/arguments/TestUseCompressedOopsFlagsWithUlimit.java still fails after JDK-8285011
  • 4a79270: 8284632: runtime/Thread/StopAtExit.java possibly leaking memory again
  • cfcba1f: 8285827: Describe the keystore.pkcs12.legacy system property in the java.security file
  • 7020595: 8284435: Add dedicated filler objects for known dead Java heap areas
  • 1f9f873: 8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled
  • cf81f6c: 8285712: LogMessageBuffer doesn't check vsnprintf return value
  • 9795ef5: 8285851: Cleanup C2AtomicParseAccess::needs_pinning()
  • 3eb661b: 8285890: Fix some @param tags
  • d9541c5: 8276202: LogFileOutput.invalid_file_vm asserts when being executed from a read only working directory
  • ... and 50 more: https://git.openjdk.java.net/jdk/compare/1f868f1d091602cc462ee0fe5fa613a3638a5f1c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 2, 2022
@openjdk openjdk bot closed this May 2, 2022
@openjdk openjdk bot removed ready rfr labels May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@bplb Pushed as commit 9d8c3bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the PushbackInputStream-mark-reset-8285745 branch May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants