Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255365: Problem list failing client manual tests #846

Closed
wants to merge 8 commits into from
Closed

8255365: Problem list failing client manual tests #846

wants to merge 8 commits into from

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Oct 23, 2020

Problem list failing client manual jtreg tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255365: Problem list failing client manual tests

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/846/head:pull/846
$ git checkout pull/846

@prrace
Copy link
Contributor Author

@prrace prrace commented Oct 23, 2020

/label add swing

@prrace
Copy link
Contributor Author

@prrace prrace commented Oct 23, 2020

/label add awt

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 23, 2020

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@prrace
The swing label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 23, 2020

@prrace
The awt label was successfully added.

@openjdk openjdk bot added the awt label Oct 23, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 23, 2020

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 24, 2020

Looks like the reference to JDK-8004301 is wrong, that bug was fixed in 2012

@prrace
Copy link
Contributor Author

@prrace prrace commented Oct 24, 2020

Looks like the reference to JDK-8004301 is wrong, that bug was fixed in 2012

Typo. Fixed.

java/awt/print/Dialog/RestoreActiveWindowTest/RestoreActiveWindowTest.java 8185429 macosx-all
java/awt/TrayIcon/DblClickActionEventTest/DblClickActionEventTest.html 8203867 macosx-all
java/awt/Frame/FrameStateTest/FrameStateTest.html 8203920 macosx-all,linux-all
javax/swing/SwingUtilities/TestTextPosInPrint.java 8227025 windows-all,linux-all

This comment has been minimized.

This comment has been minimized.

@prrace

prrace Oct 25, 2020
Author Contributor

updated.

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 25, 2020

Probably it will be useful to sort the tests, it will simplify spotting the duplicates.

# Client manual tests

java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_1.java 7131438,8022516 generic-all
java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java 7131438,8022516 generic-all

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Member

The JDK-7131438 seems specific for macOS only and the JDK-8022516 seems unrelated to these tests?

This comment has been minimized.

@prrace

prrace Oct 25, 2020
Author Contributor

The JDK-7131438 seems specific for macOS only and the JDK-8022516 seems unrelated to these tests?

8022516 is a typo. It should be 8022539. That bug is reported across plaatforms.


java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_1.java 7131438,8022516 generic-all
java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_2.java 7131438,8022516 generic-all
java/awt/Modal/WsDisabledStyle/CloseBlocker/CloseBlocker.java 7187741 generic-al

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Member

JDK-7187741 is mac and Linux specific?

This comment has been minimized.

@prrace

prrace Oct 25, 2020
Author Contributor

JDK-7187741 is mac and Linux specific?

Ok ..

java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 generic-all
java/awt/TextArea/MouseOverScrollbarWhenTyping/Test1.java 8005970 macosx-all,windows-all
javax/swing/JFileChooser/6698013/bug6698013.java 8024419 macosx-all
java/awt/Focus/8044614/bug8044614.java 8029261 generic-all

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Member

JDK-8029261 is fixed in 2013

This comment has been minimized.

@prrace

prrace Oct 25, 2020
Author Contributor

JDK-8029261 is fixed in 2013

Typo should be 8039261.

This comment has been minimized.

@mrserb

mrserb Oct 26, 2020
Member

The JDK-8039261 is not reported on the mainline

This comment has been minimized.

@prrace

prrace Oct 26, 2020
Author Contributor

ok,removed

javax/swing/JTabbedPane/4666224/bug4666224.html 8144124 macosx-all
java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java 8162380 generic-all
java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java 8163086 macosx-all
java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java 8166522,8250804 macosx-all,linux-all

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Member

JDK-8166522 is closed

This comment has been minimized.

@prrace

prrace Oct 25, 2020
Author Contributor

JDK-8166522 is closed

apparently recently closed as dup of the other one.

javax/swing/SwingUtilities/TestTextPosInPrint.java 8227025 windows-all,linux-all
java/awt/print/PrinterJob/ScaledText/ScaledText.java 8231226 macosx-all
java/awt/print/bug8023392/bug8023392.html 8231231 generic-all
java/awt/font/TextLayout/TestJustification.html 8250791 macosx-all

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Member

The JDK-8250791 initially was reported on Ubuntu, not sure should add it here or not.

@prrace
Copy link
Contributor Author

@prrace prrace commented Oct 25, 2020

Probably it will be useful to sort the tests, it will simplify spotting the duplicates.

They are sorted - by bug ID - which was much more important to me when going through well over 100 bug reports.
And I was able to sort "offline" to look for dups. so I don't want to change this.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2020

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255365: Problem list failing client manual tests

Reviewed-by: kizune, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • e8b75b1: 8255393: sun/security/util/DerValue/Indefinite.java fails with ---illegal-access=deny
  • 7cafe35: 8255352: Archive important test outputs in submit workflow
  • 888086f: 8255373: Submit workflow artifact name is always "test-results_.zip"
  • 6918818: 8255265: IdealLoopTree::iteration_split_impl does not use should_align
  • c28b011: 8255343: java/util/stream/SpliteratorTest.java fails on 32-bit platforms with "Misaligned access at address: 12"
  • b71b5b4: 8199062: Test javax/swing/text/Utilities/8134721/bug8134721.java is unstable
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/3f6abd220fa9d39bd5bd60bee3827a4680437cc6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 26, 2020
javax/swing/JTabbedPane/4666224/bug4666224.html 8144124 macosx-all
java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java 8162380 generic-all
java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java 8163086 macosx-all
java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java 8250804 macosx-all,linux-all

This comment has been minimized.

@mrserb

mrserb Oct 26, 2020
Member

I still think that the sort based on test names is better, but if the current list is sorted by the bugid then the JDK-8250804 is out of order.

This comment has been minimized.

@prrace

prrace Oct 26, 2020
Author Contributor

That's because is was under https://bugs.openjdk.java.net/browse/JDK-8163285 but that got closed as a dup of 8250804 .. which seems backwards to me as the new one is usually the dup.
But in any case I am not going to lose any sleep over this one anomaly that it caused.

This comment has been minimized.

@mrserb

mrserb Oct 26, 2020
Member

That's why I said it is a bad idea to sort using the bugid, since it is impossible to mantains this even in one review request.

@mrserb
mrserb approved these changes Oct 26, 2020
@prrace
Copy link
Contributor Author

@prrace prrace commented Oct 26, 2020

/integrate

@openjdk openjdk bot closed this Oct 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2020

@prrace Since your change was applied there have been 19 commits pushed to the master branch:

  • 49c4978: 8060202: [macosx] Test closed/java/awt/Choice/GetSizeTest/GetSizeTest fails only in MacOSX(10.10)
  • 2b47a58: 8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails
  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • e8b75b1: 8255393: sun/security/util/DerValue/Indefinite.java fails with ---illegal-access=deny
  • 7cafe35: 8255352: Archive important test outputs in submit workflow
  • 888086f: 8255373: Submit workflow artifact name is always "test-results_.zip"
  • 6918818: 8255265: IdealLoopTree::iteration_split_impl does not use should_align
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/3f6abd220fa9d39bd5bd60bee3827a4680437cc6...master

Your commit was automatically rebased without conflicts.

Pushed as commit de05b00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace prrace deleted the prrace:manual-tests branch Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants