Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285890: Fix some @param tags #8465

Closed
wants to merge 2 commits into from
Closed

Conversation

pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented Apr 29, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8465/head:pull/8465
$ git checkout pull/8465

Update a local copy of the PR:
$ git checkout pull/8465
$ git pull https://git.openjdk.java.net/jdk pull/8465/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8465

View PR using the GUI difftool:
$ git pr show -t 8465

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8465.diff

pavelrappo added 2 commits Apr 29, 2022
Bonus fixes for comments that are not included into the generated API Documentation. One of the affected comments is even not a javadoc comment.
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2022

👋 Welcome back prappo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8285890 8285890: Fix some @param tags Apr 29, 2022
@openjdk openjdk bot added the rfr label Apr 29, 2022
@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@pavelrappo The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security core-libs labels Apr 29, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 29, 2022

Webrevs

dfuch
dfuch approved these changes Apr 29, 2022
Copy link
Member

@dfuch dfuch left a comment

LGTM

@openjdk
Copy link

openjdk bot commented Apr 29, 2022

@pavelrappo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285890: Fix some @param tags

Reviewed-by: dfuchs, mullan, darcy, mchung, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • cfe67af: 8285938: ProblemList jdk/jshell/HighlightUITest.java on linux-x64
  • 67dd8a8: 8285686: Upgrade to FreeType 2.12.0
  • 64225e1: 8285919: Remove debug printout from JDK-8285093
  • df4d5cf: 8285802: AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • 694556e: 8225433: Clarify behavior of PKIXParameters.setRevocationEnabled when PKIXRevocationChecker is used
  • e98ac23: 8285793: C2: optimization of mask checks in counted loops fail in the presence of cast nodes
  • 669ac61: 8274597: Some of the dnd tests time out and fail intermittently
  • 269eae6: 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 beta2
  • c4f7a85: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
  • d3606a3: 8285390: PPC64: Handle integral division overflow during parsing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 29, 2022
Copy link
Member

@seanjmullan seanjmullan left a comment

GSSHeader looks fine.

Copy link
Member

@jddarcy jddarcy left a comment

Thanks for fixing these Pavel.

Copy link
Contributor

@bradfordwetmore bradfordwetmore left a comment

LGTM also.

@pavelrappo
Copy link
Member Author

pavelrappo commented Apr 30, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 30, 2022

Going to push as commit 3eb661b.
Since your change was applied there have been 19 commits pushed to the master branch:

  • d9541c5: 8276202: LogFileOutput.invalid_file_vm asserts when being executed from a read only working directory
  • df7fba1: 8284981: Support the vectorization of some counting-down loops in SLP
  • e54f26a: 8284992: Fix misleading Vector API doc for LSHR operator
  • 2dd882a: 8254759: [TEST_BUG] [macosx] javax/swing/JInternalFrame/4202966/IntFrameCoord.html fails
  • 23f022b: 8285945: [BACKOUT] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
  • 116763c: 8284331: Add sanity check for signal handler modification warning.
  • 95d38bb: 8285773: Replace Algorithms.eatMemory(...) with WB.fullGC() in vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
  • cd8709e: 8284883: JVM crash: guarantee(sect->end() <= sect->limit()) failed: sanity on AVX512
  • 3d07b3c: 8282227: Locale information for nb is not working properly
  • cfe67af: 8285938: ProblemList jdk/jshell/HighlightUITest.java on linux-x64
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/f42631e354d4abf7994abd92aa5def6b2ceeab3a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 30, 2022
@openjdk openjdk bot closed this Apr 30, 2022
@openjdk openjdk bot removed ready rfr labels Apr 30, 2022
@openjdk
Copy link

openjdk bot commented Apr 30, 2022

@pavelrappo Pushed as commit 3eb661b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated security
6 participants