Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255206: [macos] LicenseTest fails on macOS 11 #847

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Oct 24, 2020

I did not reproduce issue with license is not shown as per SQE report. It work as expected. However, jpackage fails due to unflatten/flatten being removed from hdiutil on macOS 11. I am not sure why it was needed, probably some legacy code. Without unflatten/flatten everything works as expected on macOS 11 and 10.5.7.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/847/head:pull/847
$ git checkout pull/847

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 24, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 24, 2020

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Oct 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 24, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2020

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255206: [macos] LicenseTest fails on macOS 11

Reviewed-by: asemenyuk, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 49c4978: 8060202: [macosx] Test closed/java/awt/Choice/GetSizeTest/GetSizeTest fails only in MacOSX(10.10)
  • 2b47a58: 8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails
  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • e8b75b1: 8255393: sun/security/util/DerValue/Indefinite.java fails with ---illegal-access=deny
  • 7cafe35: 8255352: Archive important test outputs in submit workflow
  • 888086f: 8255373: Submit workflow artifact name is always "test-results_.zip"
  • 6918818: 8255265: IdealLoopTree::iteration_split_impl does not use should_align
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/63ce304ea4d816872b73d36abe42b6debec694a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 26, 2020
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Oct 26, 2020

/integrate

@openjdk openjdk bot closed this Oct 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2020

@sashamatveev Since your change was applied there have been 34 commits pushed to the master branch:

  • ca8bba6: 8238263: Create at-requires mechanism for containers
  • a7fa1b7: 8251994: VM crashed running TestComplexAddrExpr.java test with -XX:UseAVX=X
  • b498433: 8254825: Monitoring available clipboard formats should be done via new Windows APIs
  • de05b00: 8255365: Problem list failing client manual tests
  • 49c4978: 8060202: [macosx] Test closed/java/awt/Choice/GetSizeTest/GetSizeTest fails only in MacOSX(10.10)
  • 2b47a58: 8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails
  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/63ce304ea4d816872b73d36abe42b6debec694a7...master

Your commit was automatically rebased without conflicts.

Pushed as commit 8ca59c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants