8285399: JNI exception pending in awt_GraphicsEnv.c:1432

[prrace]

This is a theoretical/potential case of calling JNI methods with a possible execption pending.
As noted in the eval of the bug report, we no longer follow the practice that AWT_LOCK is
called only at the start of a native method and AWT_UNLOCK at the end, if indeed we ever did.
But it seems to be implied in how they are handling exceptions.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8285399: JNI exception pending in awt_GraphicsEnv.c:1432

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8493/head:pull/8493
$ git checkout pull/8493

Update a local copy of the PR:
$ git checkout pull/8493
$ git pull https://git.openjdk.java.net/jdk pull/8493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8493

View PR using the GUI difftool:
$ git pr show -t 8493

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8493.diff

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (67611235)
• 00: Full (16726225)

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285399: JNI exception pending in awt_GraphicsEnv.c:1432

Reviewed-by: azvegint, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 314 new commits pushed to the master branch:

• da8fd45: 8287119: Add Distrust.java to ProblemList
• b33c6e5: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes
• ba23f14: 8287052: comparing double to max_intx gives unexpected results
• 7b274fe: 8285513: JFR: Add more static support for event classes
• 087bccf: 8286978: SIGBUS in libz during CDS initialization
• 4587337: 8286858: Remove dead code in sun.reflect.misc.MethodUtil
• 6d56caf: 8285962: NimbusDefaults has a typo in a L&F property
• d5d19f5: 8287013: StringConcatFactory: remove short and byte mixers/prependers
• 828dc89: 8286893: G1: Recent card set coarsening statistics wrong
• 6569666: 8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong
• ... and 304 more: https://git.openjdk.java.net/jdk/compare/3eb661bbe7151f3a7e949b6518f57896c2bd4136...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/integrate

[openjdk]

Going to push as commit c156bcc.
Since your change was applied there have been 315 commits pushed to the master branch:

• 7c08647: 8287099: Clean up terminology regarding doc comment descriptions.
• da8fd45: 8287119: Add Distrust.java to ProblemList
• b33c6e5: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes
• ba23f14: 8287052: comparing double to max_intx gives unexpected results
• 7b274fe: 8285513: JFR: Add more static support for event classes
• 087bccf: 8286978: SIGBUS in libz during CDS initialization
• 4587337: 8286858: Remove dead code in sun.reflect.misc.MethodUtil
• 6d56caf: 8285962: NimbusDefaults has a typo in a L&F property
• d5d19f5: 8287013: StringConcatFactory: remove short and byte mixers/prependers
• 828dc89: 8286893: G1: Recent card set coarsening statistics wrong
• ... and 305 more: https://git.openjdk.java.net/jdk/compare/3eb661bbe7151f3a7e949b6518f57896c2bd4136...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit c156bcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.