Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled #8495

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented May 2, 2022

Hi all,

Several tests in compiler/c2/irTests fail if C2 is not available.

The following 7 tests use C2-only VM falgs.

compiler/c2/irTests/TestSkeletonPredicates.java
compiler/c2/irTests/TestFewIterationsCountedLoop.java
compiler/c2/irTests/TestDuplicateBackedge.java
compiler/c2/irTests/TestStripMiningDropsSafepoint.java
compiler/c2/irTests/TestCountedLoopSafepoint.java
compiler/c2/irTests/TestLongRangeChecks.java
compiler/c2/irTests/TestSuperwordFailsUnrolling.java

The following two tests assert that C2 must be available.

compiler/c2/irTests/TestIRLShiftIdeal_XPlusX_LShiftC.java   
compiler/c2/irTests/TestIRAddIdealNotXPlusC.java

It would be better to add @requires vm.compiler2.enabled to these tests.

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8495/head:pull/8495
$ git checkout pull/8495

Update a local copy of the PR:
$ git checkout pull/8495
$ git pull https://git.openjdk.java.net/jdk pull/8495/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8495

View PR using the GUI difftool:
$ git pr show -t 8495

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8495.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@DamonFool The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 2, 2022
@mlbridge
Copy link

mlbridge bot commented May 2, 2022

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented May 2, 2022

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285980: Several tests in compiler/c2/irTests miss @requires vm.compiler2.enabled

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9795ef5: 8285851: Cleanup C2AtomicParseAccess::needs_pinning()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 2, 2022
@DamonFool
Copy link
Member Author

Looks good and trivial.

Thanks @TobiHartmann for the review.
/integrate

@openjdk
Copy link

openjdk bot commented May 2, 2022

Going to push as commit 1f9f873.
Since your change was applied there have been 2 commits pushed to the master branch:

  • cf81f6c: 8285712: LogMessageBuffer doesn't check vsnprintf return value
  • 9795ef5: 8285851: Cleanup C2AtomicParseAccess::needs_pinning()

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 2, 2022
@openjdk openjdk bot closed this May 2, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@DamonFool Pushed as commit 1f9f873.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DamonFool DamonFool deleted the JDK-8285980 branch May 2, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants