Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8134640 ( Left Insets Margin Test ) moved to open repo from closed #8500

wants to merge 8 commits into from


Copy link

@TejeshR13 TejeshR13 commented May 2, 2022

The Test had been updated to use all Supported Look and Feel in closed repo. The same has been moved to open repo.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8134640


  • JDK-8134640: [TESTBUG] Enhance closed/javax/swing/JRadioButton/4380543/ to use all the supported L&F ⚠️ Title mismatch between PR and JBS. ⚠️ Issue is not open.


Using git

Checkout this PR locally:
$ git fetch pull/8500/head:pull/8500
$ git checkout pull/8500

Update a local copy of the PR:
$ git checkout pull/8500
$ git pull pull/8500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8500

View PR using the GUI difftool:
$ git pr show -t 8500

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back TejeshR13! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link

openjdk bot commented May 2, 2022

⚠️ @TejeshR13 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 2, 2022
Copy link

openjdk bot commented May 2, 2022

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client label May 2, 2022
Copy link

mlbridge bot commented May 2, 2022


@@ -0,0 +1,237 @@
* Copyright (c) 2002,2022, Oracle and/or its affiliates. All rights reserved.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess there should be a space between 2002, and 2022 else validate-source task might fail.

Copy link

prrace commented May 5, 2022

You need to submit this under a NEW bug ID.
You already used 8134640 to push an update to the test whilst it was still closed and it was resolved in a build a couple of weeks ago. We can't re-use it for this in a different build, that would be wrong !

Copy link

prrace commented May 5, 2022

Actually withdraw this PR and let's re-do it properly.

@TejeshR13 TejeshR13 closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
client rfr Pull request is ready for review
3 participants