Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc #8508

Closed

Conversation

backwaterred
Copy link
Contributor

@backwaterred backwaterred commented May 2, 2022

Adds missing classpath exception to the header of two GPLv2 files.

Requested here.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issue

  • JDK-8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8508/head:pull/8508
$ git checkout pull/8508

Update a local copy of the PR:
$ git checkout pull/8508
$ git pull https://git.openjdk.java.net/jdk pull/8508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8508

View PR using the GUI difftool:
$ git pr show -t 8508

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8508.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back backwaterred! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 2, 2022

@backwaterred To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@backwaterred backwaterred marked this pull request as ready for review May 4, 2022 16:31
@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2022
@sviswa7
Copy link

sviswa7 commented May 4, 2022

/label core-libs

@openjdk
Copy link

openjdk bot commented May 4, 2022

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286029: Add classpath exemption to globals_vectorApiSupport_***.S.inc

Reviewed-by: sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • c5a0687: 8285976: compiler/exceptions/OptimizeImplicitExceptions.java can't pass with -XX:+DeoptimizeALot
  • df8c2be: 8279598: Provide adapter from RandomGenerator to Random
  • 497a94f: 8286138: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on macosx-aarch64
  • 7b7207a: 8280003: C1: Reconsider uses of logical_and immediates in LIRGenerator::do_getObjectSize
  • 17cc713: 8274112: (fc) Tune FileChannel.transferTo()
  • 7424f47: 8286114: [test] show real exception in bomb call in sun/rmi/runtime/Log/checkLogging/CheckLogging.java
  • 29c2e54: 8286092: Remove dead windows stack code
  • 4e1e76a: 8278757: [s390] Implement AES Counter Mode Intrinsic
  • 4b2c822: 8282477: [x86, aarch64] vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler
  • ca9d039: 8285934: Remove unimplemented MemTracker::init_tracking_level
  • ... and 20 more: https://git.openjdk.java.net/jdk/compare/9d8c3bf9f8bc2083c44b7203e81c007d685b9b61...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated core-libs core-libs-dev@openjdk.org labels May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@sviswa7
The core-libs label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 4, 2022

Webrevs

@backwaterred
Copy link
Contributor Author

Thank you @sviswa7.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@backwaterred
Your change (at version cdae131) is now ready to be sponsored by a Committer.

@sviswa7
Copy link

sviswa7 commented May 5, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented May 5, 2022

Going to push as commit 6a1b145.
Since your change was applied there have been 57 commits pushed to the master branch:

  • 59ef76a: 8285497: Add system property for Java SE specification maintenance version
  • 6d7e446: 8283306: re-resolving indirect call to non-entrant nmethod can crash
  • 4957bc7: 8286056: AArch64: clarify uses of MacroAssembler::far_call/MacroAssembler::far_jump
  • e7adc28: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest
  • 9644a31: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file
  • 2f995c8: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java
  • 2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
  • 1bba640: 8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing
  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ... and 47 more: https://git.openjdk.java.net/jdk/compare/9d8c3bf9f8bc2083c44b7203e81c007d685b9b61...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 5, 2022
@openjdk openjdk bot closed this May 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@sviswa7 @backwaterred Pushed as commit 6a1b145.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants