JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" #8509

honkar-jdk · 2022-05-02T21:02:02Z

This test case tests the functionality of setAlwaysOnTop.
Documentation on setAlwaysOnTop: Link

The following test case was seen to fail on windows and linux platforms. With the proposed fix, the test case works on all platforms.

The test case tests alwaysOnTop for the following three cases:

JDialog with no parent/owner
JDialog with JFrame as owner
JDialog with another JDialog as owner

Each of the three cases mentioned above is tested under 3 scenarios:

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

Reviewers

Phil Race (@prrace - Reviewer)
Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8509/head:pull/8509
$ git checkout pull/8509

Update a local copy of the PR:
$ git checkout pull/8509
$ git pull https://git.openjdk.java.net/jdk pull/8509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8509

View PR using the GUI difftool:
$ git pr show -t 8509

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8509.diff

bridgekeeper · 2022-05-02T21:03:46Z

👋 Welcome back honkar-jdk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2022-05-02T21:05:51Z

@honkar-jdk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2022-05-02T21:09:56Z

Webrevs

azuev-java · 2022-05-04T17:58:17Z

test/jdk/java/awt/Window/MultiWindowApp/ChildAlwaysOnTopTest.java

+                saveScreenCapture(caseNo , 1);
+                throw new RuntimeException("Scenario 1: alwaysOnTop window is "+
+                        "sent back by another child window with setVisible(). "
+                        + color);


I see that we are doing a number of test scenarios but test fails immediately when first error occurs. Can we continue testing, save all screenshots and remember all the failures and then fail at the end if there were errors listing all the errors in all the LaF's that were happened during the run?

@azuev-java Thank you for the suggestion. I can definitely add this functionality to the test for better failure analysis.

I think that's a reasonable suggestion in general to bear in mind when writing tests.
I've seen tests which bail at the first failure and you wish you knew how the rest of it worked out ..
Like (say) a test that iterates over the 4 available L&Fs might be a case.

@prrace Thank you for the inputs. Will make a note to add it for future similar test scenarios too.

Updated test case to continue testing all scenarios and to throw Exception at the end (in case test fails in any of the scenarios)

… of failure

azuev-java · 2022-05-05T15:54:33Z

test/jdk/java/awt/Window/MultiWindowApp/ChildAlwaysOnTopTest.java

+            });
+            System.out.println("Case "+ caseNo + errorMsg[scenarioNo - 1]
+                    +" Expected Color: "+ expectedColor +" vs Actual Color: "
+                    + actualColor);


Here instead of just printing out the error i would save it into the static StringBuilder that i would allocate at the beginning of the test. Then when we are concluding testing i would just check if the buffer is empty and if it is not i would throw an RuntimeException with the buffer content. This way we would have all the errors reported by the JavaTest suite in the HTML report and this will make it into the whatever testing environment report we are running tests in. Also that would replace the errorFlag variable since emptiness of the buffer will be an indication of test pass.

@azuev-java Thank you for the suggestion. I have updated the PR with the changes.

openjdk · 2022-05-05T19:18:28Z

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

Reviewed-by: prr, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

4957bc7: 8286056: AArch64: clarify uses of MacroAssembler::far_call/MacroAssembler::far_jump
e7adc28: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest
9644a31: 8285616: [macos] Incorrect path for launcher-as-service.txt in .cfg file
2f995c8: 8286199: ProblemList jdk/jshell/ExternalEditorTest.java
2293448: 8272352: Java launcher can not parse Chinese character when system locale is set to UTF-8
1bba640: 8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing
5ac7186: 8282559: Allow multiple search terms in javadoc search
7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
... and 10 more: https://git.openjdk.java.net/jdk/compare/bb022b24cfdad9d6826140c6b26c46f480e7457d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @azuev-java) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

honkar-jdk · 2022-05-05T21:16:19Z

/integrate

openjdk · 2022-05-05T21:18:20Z

@honkar-jdk
Your change (at version 666a285) is now ready to be sponsored by a Committer.

prrace · 2022-05-09T17:38:46Z

/sponsor

openjdk · 2022-05-09T17:39:53Z

Going to push as commit 837928b.
Since your change was applied there have been 54 commits pushed to the master branch:

397d095: 8285743: Ensure each IntegerPolynomial object is only created once
29ccb8f: 8285914: AppCDS crash when using shared archive with old class file
fe6e0c0: 8286371: Avoid use of deprecated str[n]icmp
97a9835: 8274517: java/util/DoubleStreamSums/CompensatedSums.java fails with expected [true] but found [false]
034f20f: 8212136: Remove finalizer implementation in SSLSocketImpl
36e4df9: 8285516: clearPassword should be called in a finally try block
b849efd: 8285923: [REDO] JDK-8285802 AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities
f143386: 8286293: Tests ShortResponseBody and ShortResponseBodyWithRetry should use less resources
64b05cc: 8286346: 3-parameter version of AllocateHeap should not ignore AllocFailType
4f5d73f: 8286294: ForkJoinPool.commonPool().close() spins
... and 44 more: https://git.openjdk.java.net/jdk/compare/bb022b24cfdad9d6826140c6b26c46f480e7457d...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-05-09T17:40:10Z

@prrace @honkar-jdk Pushed as commit 837928b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

test case changes for alwaysOnTop

1b7e59f

openjdk bot added the rfr Pull request is ready for review label May 2, 2022

openjdk bot added the client client-libs-dev@openjdk.org label May 2, 2022

azuev-java reviewed May 4, 2022

View reviewed changes

honkar-jdk added 2 commits May 4, 2022 15:30

added changes to continue testing and exception thrown at end in case…

396d565

… of failure

Merge branch 'master' into AlwaysOnTop_8222323

e4b7740

azuev-java reviewed May 5, 2022

View reviewed changes

honkar-jdk added 2 commits May 5, 2022 11:16

added error msgs to StringBuffer

79120c7

removed commented line

666a285

prrace approved these changes May 5, 2022

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022

azuev-java approved these changes May 5, 2022

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label May 5, 2022

openjdk bot added the integrated Pull request has been integrated label May 9, 2022

openjdk bot closed this May 9, 2022

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 9, 2022

JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" #8509

JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop" #8509

Uh oh!

Conversation

honkar-jdk commented May 2, 2022 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented May 2, 2022

Uh oh!

openjdk bot commented May 2, 2022

Uh oh!

mlbridge bot commented May 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

azuev-java May 4, 2022

Choose a reason for hiding this comment

Uh oh!

honkar-jdk May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prrace May 4, 2022

Choose a reason for hiding this comment

Uh oh!

honkar-jdk May 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

honkar-jdk May 4, 2022

Choose a reason for hiding this comment

Uh oh!

azuev-java May 5, 2022

Choose a reason for hiding this comment

Uh oh!

honkar-jdk May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

honkar-jdk commented May 5, 2022

Uh oh!

openjdk bot commented May 5, 2022

Uh oh!

prrace commented May 9, 2022

Uh oh!

openjdk bot commented May 9, 2022

Uh oh!

openjdk bot commented May 9, 2022

Uh oh!

Uh oh!

honkar-jdk commented May 2, 2022 •

edited by openjdk bot

Loading

mlbridge bot commented May 2, 2022 •

edited

Loading

honkar-jdk May 4, 2022 •

edited

Loading

honkar-jdk May 4, 2022 •

edited

Loading

honkar-jdk May 5, 2022 •

edited

Loading

openjdk bot commented May 5, 2022 •

edited

Loading