Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8285977: Add links to IEEE 754 specification #8511

Closed
wants to merge 2 commits into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented May 2, 2022

Please review the addition of @-see links from classes that mention the IEEE 754 floating-point standard to an IEEE page about the standard. The URL in the initial version of the PR is the top search result on the IEEE home page for "754 standard".

Another candidate page to use is

https://ieeexplore.ieee.org/servlet/opac?punumber=8766227

which is (apparently) a stable citation page for the standard.

These links may be upgraded to the the forthcoming @-spec facility in the future. ( JDK-6251738).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8511/head:pull/8511
$ git checkout pull/8511

Update a local copy of the PR:
$ git checkout pull/8511
$ git pull https://git.openjdk.java.net/jdk pull/8511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8511

View PR using the GUI difftool:
$ git pr show -t 8511

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8511.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label May 2, 2022
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

I endorse the use of a URL with a host-name like standards.ieee.org

@openjdk
Copy link

openjdk bot commented May 2, 2022

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285977: Add links to IEEE 754 specification

Reviewed-by: jjg, iris, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 4434c7d: 8265360: several compiler/whitebox tests fail with "private compiler.whitebox.SimpleTestCaseHelper(int) must be compiled"
  • ffca23a: 8284490: Remove finalizer method in java.security.jgss
  • 0f62cb6: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 6fcd322: 8279622: C2: miscompilation of map pattern as a vector reduction
  • af1ee1c: 8283684: IGV: speed up filter application
  • 7a48351: 8280568: IGV: Phi inputs and pinned nodes are not scheduled correctly
  • 64b5b2b: 8282828: CDS uncompressed oops archive is not deterministic
  • 45ca81f: 8285915: failure_handler: gather the contents of /etc/hosts file
  • 3420a1a: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • fbcd874: 8285979: G1: G1SegmentedArraySegment::header_size() is incorrect since JDK-8283368
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/3eb661bbe7151f3a7e949b6518f57896c2bd4136...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 2, 2022
@mlbridge
Copy link

mlbridge bot commented May 2, 2022

Webrevs

bplb
bplb approved these changes May 2, 2022
@rgiulietti
Copy link
Contributor

rgiulietti commented May 3, 2022

What about the DOI URL? Probably even more stable.
https://doi.org/10.1109/IEEESTD.2019.8766229

@mlbridge
Copy link

mlbridge bot commented May 3, 2022

Mailing list message from Rony G. Flatscher on core-libs-dev:

On 03.05.2022 10:28, Raffaello Giulietti wrote:

Maybe informal links to the resources made available via the web by the IEEE 754 editor, Mike F. Cowlishaw, could be helpful:

- <http://speleotrove.com/decimal/>
- Previous standard: <https://www.iso.org/standard/57469.html> with <http://speleotrove.com/misc/IEEE754-errata.html>
- Current standard: <https://www.iso.org/standard/80985.html> with <http://speleotrove.com/misc/IEEE754-errata-2019.html>

---rony

@mlbridge
Copy link

mlbridge bot commented May 3, 2022

Mailing list message from Joe Darcy on core-libs-dev:

Hello,

While informative, I think some kind of official link to the IEEE 754
document is more appropriate in this context.

-Joe

On 5/3/2022 2:59 AM, Rony G. Flatscher wrote:

On 03.05.2022 10:28, Raffaello Giulietti wrote:

Maybe informal links to the resources made available via the web by
the IEEE 754 editor, Mike F. Cowlishaw, could be helpful:

- <http://speleotrove.com/decimal/>
- Previous standard: <https://www.iso.org/standard/57469.html> with
<http://speleotrove.com/misc/IEEE754-errata.html>
- Current standard: <https://www.iso.org/standard/80985.html> with
<http://speleotrove.com/misc/IEEE754-errata-2019.html>

---rony

@jddarcy
Copy link
Member Author

jddarcy commented May 3, 2022

What about the DOI URL? Probably even more stable. https://doi.org/10.1109/IEEESTD.2019.8766229

Hmm. I'd rather use the IEEE URL for now; if that turns out to problematic, we can switch to the DOI one.

@rgiulietti
Copy link
Contributor

rgiulietti commented May 3, 2022

The DOI URL currently brings you to exactly the same IEEExplore page.

@jddarcy
Copy link
Member Author

jddarcy commented May 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 3, 2022

Going to push as commit 3cbf769.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 4434c7d: 8265360: several compiler/whitebox tests fail with "private compiler.whitebox.SimpleTestCaseHelper(int) must be compiled"
  • ffca23a: 8284490: Remove finalizer method in java.security.jgss
  • 0f62cb6: 8285921: serviceability/dcmd/jvmti/AttachFailed/AttachReturnError.java fails on Alpine
  • 6fcd322: 8279622: C2: miscompilation of map pattern as a vector reduction
  • af1ee1c: 8283684: IGV: speed up filter application
  • 7a48351: 8280568: IGV: Phi inputs and pinned nodes are not scheduled correctly
  • 64b5b2b: 8282828: CDS uncompressed oops archive is not deterministic
  • 45ca81f: 8285915: failure_handler: gather the contents of /etc/hosts file
  • 3420a1a: 8286013: Incorrect test configurations for compiler/stable/TestStableShort.java
  • fbcd874: 8285979: G1: G1SegmentedArraySegment::header_size() is incorrect since JDK-8283368
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/3eb661bbe7151f3a7e949b6518f57896c2bd4136...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 3, 2022
@openjdk openjdk bot closed this May 3, 2022
@openjdk openjdk bot removed ready rfr labels May 3, 2022
@openjdk
Copy link

openjdk bot commented May 3, 2022

@jddarcy Pushed as commit 3cbf769.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
5 participants