Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing #8512

Closed
wants to merge 3 commits into from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented May 2, 2022

The test counts all "system" threads before the execution and expects that this number remains the same during test execution.
This makes the test fragile - JVM may start internal threads, some threads may end.

The fix updates the test:

  • the test checks only test threads, and verify that the live threads are reported by GetAllThreads and terminated threads are not reported;
  • dropped "system" thread counting stuff;
  • added proper deallocation of GetThreadInfo results.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issue

  • JDK-8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8512/head:pull/8512
$ git checkout pull/8512

Update a local copy of the PR:
$ git checkout pull/8512
$ git pull https://git.openjdk.java.net/jdk pull/8512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8512

View PR using the GUI difftool:
$ git pr show -t 8512

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8512.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 2, 2022

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 2, 2022
@openjdk
Copy link

openjdk bot commented May 2, 2022

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability label May 2, 2022
@mlbridge
Copy link

mlbridge bot commented May 2, 2022

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Alex,
It looks good to me.
Thank you for taking care about this!
Serguei

@sspitsyn
Copy link
Contributor

sspitsyn commented May 3, 2022

Should we remove prefix "[LOOM] " from the bug title?

@openjdk
Copy link

openjdk bot commented May 3, 2022

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 3, 2022
@alexmenkov alexmenkov changed the title 8284027: [LOOM] vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing 8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing May 3, 2022
@alexmenkov
Copy link
Author

alexmenkov commented May 3, 2022

Should we remove prefix "[LOOM] " from the bug title?

Done

int i, j;
bool found;
Copy link
Member

@dholmes-ora dholmes-ora May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this isn't old style C code, we don't have to declare all variables up front. New variables should be declared where needed.

Copy link
Author

@alexmenkov alexmenkov May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)
fixed.

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Update looks good.
Thanks,
Serguei

@alexmenkov
Copy link
Author

alexmenkov commented May 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 5, 2022

Going to push as commit 1bba640.
Since your change was applied there have been 92 commits pushed to the master branch:

  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
  • dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
  • 9d2f591: 8285987: executing shell scripts without #! fails on Alpine linux
  • fd41e65: 8286115: G1: G1RemSetArrayOfCardsEntriesBase off-by-one error
  • 7e88ff8: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • 81d7475: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 4a5e7a1: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
  • 1bb4de2: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/bba456a8dbf9027e4b015567c17a79fc7441aa08...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label May 5, 2022
@openjdk openjdk bot closed this May 5, 2022
@openjdk openjdk bot removed ready rfr labels May 5, 2022
@openjdk
Copy link

openjdk bot commented May 5, 2022

@alexmenkov Pushed as commit 1bba640.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@alexmenkov alexmenkov deleted the getAllThreads_test branch May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated serviceability
4 participants