8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing

[alexmenkov]

The test counts all "system" threads before the execution and expects that this number remains the same during test execution.
This makes the test fragile - JVM may start internal threads, some threads may end.

The fix updates the test:

• the test checks only test threads, and verify that the live threads are reported by GetAllThreads and terminated threads are not reported;
• dropped "system" thread counting stuff;
• added proper deallocation of GetThreadInfo results.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 reviews required, with at least 1 reviewer)

Issue

• JDK-8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8512/head:pull/8512
$ git checkout pull/8512

Update a local copy of the PR:
$ git checkout pull/8512
$ git pull https://git.openjdk.java.net/jdk pull/8512/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8512

View PR using the GUI difftool:
$ git pr show -t 8512

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8512.diff

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (aa74cf6d)
• 01: Full - Incremental (1539460c)
• 00: Full (a7ae12d8)

[sspitsyn]

Alex,
It looks good to me.
Thank you for taking care about this!
Serguei

[sspitsyn]

Should we remove prefix "[LOOM] " from the bug title?

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8284027: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/ is failing

Reviewed-by: sspitsyn, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• 158d871: 8285693: Create an automated test for JDK-4702199
• bb022b2: 8285470: Improve handling of @inheritdoc
• 09e6ee9: 8255552: Add DES/3DES/MD5 to jdk.security.legacyAlgorithms
• 4d30a1e: 8284220: TypeMirror#toString omits enclosing class names after JDK-8281238
• 28e6d80: 8285869: Selective cleanup in doclint Checker class
• 00e6c63: 8277090: jsr166 refresh for jdk19
• c5a0687: 8285976: compiler/exceptions/OptimizeImplicitExceptions.java can't pass with -XX:+DeoptimizeALot
• df8c2be: 8279598: Provide adapter from RandomGenerator to Random
• 497a94f: 8286138: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on macosx-aarch64
• 7b7207a: 8280003: C1: Reconsider uses of logical_and immediates in LIRGenerator::do_getObjectSize
• ... and 69 more: https://git.openjdk.java.net/jdk/compare/bba456a8dbf9027e4b015567c17a79fc7441aa08...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[alexmenkov]

Should we remove prefix "[LOOM] " from the bug title?

Done

[dholmes-ora]

Nit: this isn't old style C code, we don't have to declare all variables up front. New variables should be declared where needed.

[alexmenkov]

ok :)
fixed.

[sspitsyn]

Update looks good.
Thanks,
Serguei

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 1bba640.
Since your change was applied there have been 92 commits pushed to the master branch:

• 5ac7186: 8282559: Allow multiple search terms in javadoc search
• 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
• ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
• dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
• 9d2f591: 8285987: executing shell scripts without #! fails on Alpine linux
• fd41e65: 8286115: G1: G1RemSetArrayOfCardsEntriesBase off-by-one error
• 7e88ff8: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
• 81d7475: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
• 4a5e7a1: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
• 1bb4de2: 8285956: (fs) Excessive default poll interval in PollingWatchService
• ... and 82 more: https://git.openjdk.java.net/jdk/compare/bba456a8dbf9027e4b015567c17a79fc7441aa08...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 1bba640.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.