Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails #852

Closed
wants to merge 2 commits into from

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Oct 25, 2020

The test fails because of a missed null check for the next method:
https://docs.oracle.com/en/java/javase/15/docs/api/java.desktop/javax/swing/JTabbedPane.html#getBoundsAt(int)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/852/head:pull/852
$ git checkout pull/852

serb
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 25, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2020

@mrserb The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing label Oct 25, 2020
@@ -105,6 +105,9 @@ private void test(String step) {
this.passed = true;
for (int index = 0; index < this.pane.getTabCount(); index++) {
Rectangle bounds = this.pane.getBoundsAt(index);
if (bounds == null) {

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Author Member

The Aqua L&F uses scroll for the tabs so some of them may be invisible, and then null is returned as specified by the getBoundsAt(index)

This comment has been minimized.

@prsadhuk

prsadhuk Oct 25, 2020
Contributor

Looks ok but it will be good to have a mach5 job listed in JBS testing this modified test on all platforms.

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Author Member

Looks ok but it will be good to have a mach5 job listed in JBS testing this modified test on all platforms.

done

This comment has been minimized.

@prsadhuk

prsadhuk Oct 25, 2020
Contributor

One thing...I think it will be good to replace throwing Error with RuntimeException in the test

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Author Member

It does not matter which exception or error we will throw, they are treated the same.

serb
@mrserb mrserb marked this pull request as ready for review Oct 25, 2020
@openjdk openjdk bot added the rfr label Oct 25, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 25, 2020

Webrevs

@@ -81,6 +79,7 @@ public void run() {
JFrame frame = new JFrame();

This comment has been minimized.

@prsadhuk

prsadhuk Oct 25, 2020
Contributor

I guess the frame needs to be disposed in finally block.

This comment has been minimized.

@mrserb

mrserb Oct 25, 2020
Author Member

It is already disposed of at line #90 but only for automated mode, if the test run manually the frame will not be disposed of + an exception is also will not throw.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2020

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8028281: [TEST_BUG] [macosx] javax/swing/JTabbedPane/7024235/Test7024235.java fails

Reviewed-by: psadhukhan, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • e8b75b1: 8255393: sun/security/util/DerValue/Indefinite.java fails with ---illegal-access=deny
  • 7cafe35: 8255352: Archive important test outputs in submit workflow
  • 888086f: 8255373: Submit workflow artifact name is always "test-results_.zip"
  • 6918818: 8255265: IdealLoopTree::iteration_split_impl does not use should_align
  • c28b011: 8255343: java/util/stream/SpliteratorTest.java fails on 32-bit platforms with "Misaligned access at address: 12"
  • b71b5b4: 8199062: Test javax/swing/text/Utilities/8134721/bug8134721.java is unstable
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/6545e19fcc02d570b27fb426939307f80ae171c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 26, 2020
@prrace
prrace approved these changes Oct 26, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Oct 26, 2020

/integrate

@openjdk openjdk bot closed this Oct 26, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 26, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2020

@mrserb Since your change was applied there have been 16 commits pushed to the master branch:

  • 83a91bf: 8253734: C2: Optimize Move nodes
  • 6666dcb: 8237363: Remove automatic is in heap verification in OopIterateClosure
  • fa64477: 8255301: Common and strengthen the code in ciMemberName and ciMethodHandle
  • 9b5a2a6: 8255349: Vector API issues on Big Endian
  • e8b75b1: 8255393: sun/security/util/DerValue/Indefinite.java fails with ---illegal-access=deny
  • 7cafe35: 8255352: Archive important test outputs in submit workflow
  • 888086f: 8255373: Submit workflow artifact name is always "test-results_.zip"
  • 6918818: 8255265: IdealLoopTree::iteration_split_impl does not use should_align
  • c28b011: 8255343: java/util/stream/SpliteratorTest.java fails on 32-bit platforms with "Misaligned access at address: 12"
  • b71b5b4: 8199062: Test javax/swing/text/Utilities/8134721/bug8134721.java is unstable
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/6545e19fcc02d570b27fb426939307f80ae171c6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2b47a58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb:JDK-8028281 branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants