8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails

[manukumarvs]

Removing MissingDragExitEventTest.java from ProblemList as JDK-8274597 already fixed the test and it's working fine now.

Testing:
MissingDragExitEventTest.java test has been run 10 times on all 3 platforms and got all Pass.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

• JDK-8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8529/head:pull/8529
$ git checkout pull/8529

Update a local copy of the PR:
$ git checkout pull/8529
$ git pull https://git.openjdk.java.net/jdk pull/8529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8529

View PR using the GUI difftool:
$ git pr show -t 8529

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8529.diff

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[manukumarvs]

/label client

[openjdk]

@manukumarvs
The client label was successfully added.

[mlbridge]

Webrevs

• 00: Full (c9ab3139)

[prrace]

So a comment in the bug report says

I am not seeing this test fail but I think it needs to be problem listed anyway as it "drops" (pastes) "1234567890"
into the terminal window that runs jtreg. Need to figure out how to clean up what it is dragging.
This is occurring on Mac.

Is that resolved ? If so by what ?

[manukumarvs]

@prrace Yes, that issue is resolved by setting the 'outer.translate(-20, 0)' instead of 'outer.translate(-40, 0)'. It will drag the contents(the text "1234567890") from inside and just go -20px from the frame(just enough to generate the DragExit event) and will again come back, but it will never drop the content anywhere. I have tested it manually in MacOS with a terminal window open behind and it never pasted anything there.

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• 2939553: 8282351: jpackage does not work if class file has $$ in the name on windows
• 61450bb: 8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory
• c28a636: 8286442: ProblemList compiler/c2/irTests/TestSkeletonPredicates.java in -Xcomp mode
• 54e3308: 8286348: incorrect use of @serial
• b0d2b0a: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
• 902b1dd: 8284686: Interval of < 1 ms disables ExecutionSample events
• 02e5fc0: 8286435: JDK-8284316 caused validate-source to fail in Tier1
• 6a7c023: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
• 40470d8: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out
• 837928b: 8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
• ... and 69 more: https://git.openjdk.java.net/jdk/compare/0462d5a25258458ec7f40d76b9d910ee529f3647...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[manukumarvs]

/integrate

[openjdk]

@manukumarvs
Your change (at version c9ab313) is now ready to be sponsored by a Committer.

[akolarkunnu]

/sponsor

[openjdk]

Going to push as commit 9a3cb93.
Since your change was applied there have been 80 commits pushed to the master branch:

• ace4230: 8261650: Add a comment with details for MTLVC_MAX_INDEX
• 2939553: 8282351: jpackage does not work if class file has $$ in the name on windows
• 61450bb: 8283651: nsk/jvmti/SuspendThread/suspendthrd003 may leak native memory
• c28a636: 8286442: ProblemList compiler/c2/irTests/TestSkeletonPredicates.java in -Xcomp mode
• 54e3308: 8286348: incorrect use of @serial
• b0d2b0a: 8286331: jni_GetStringUTFChars() uses wrong heap allocator
• 902b1dd: 8284686: Interval of < 1 ms disables ExecutionSample events
• 02e5fc0: 8286435: JDK-8284316 caused validate-source to fail in Tier1
• 6a7c023: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
• 40470d8: 8284550: test failure_handler is not properly invoking jhsdb jstack, resulting in failure to produce a stack when a test times out
• ... and 70 more: https://git.openjdk.java.net/jdk/compare/0462d5a25258458ec7f40d76b9d910ee529f3647...master

Your commit was automatically rebased without conflicts.

[openjdk]

@akolarkunnu @manukumarvs Pushed as commit 9a3cb93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.