Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12 #8532

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented May 4, 2022

2 open tests were seen to be failing in macos12 which happen to have same root cause as
8273506: java Robot API did the 'm' keypress and caused /awt/event/Ke....

With that fix being committed, testing on intended macos12 systems are not able to reproduce this failures so we can remove from Problemlist. CI jobs links are in JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 reviewer)

Issue

  • JDK-8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8532/head:pull/8532
$ git checkout pull/8532

Update a local copy of the PR:
$ git checkout pull/8532
$ git pull https://git.openjdk.java.net/jdk pull/8532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8532

View PR using the GUI difftool:
$ git pr show -t 8532

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8532.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2022

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@prsadhuk
Copy link
Contributor Author

prsadhuk commented May 4, 2022

/label add client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@prsadhuk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented May 4, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented May 5, 2022

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 5ac7186: 8282559: Allow multiple search terms in javadoc search
  • 7022543: 8286195: ProblemList test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java
  • ede06c3: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8
  • dce860a: 8285947: Avoid redundant HashMap.containsKey calls in ZoneName
  • 9d2f591: 8285987: executing shell scripts without #! fails on Alpine linux
  • fd41e65: 8286115: G1: G1RemSetArrayOfCardsEntriesBase off-by-one error
  • 7e88ff8: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • 81d7475: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
  • 4a5e7a1: 8282555: Missing memory edge when spilling MoveF2I, MoveD2L etc
  • 1bb4de2: 8285956: (fs) Excessive default poll interval in PollingWatchService
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/4b2c82200fdc01de868cf414e40a4d891e753f89...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 5, 2022
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 12, 2022

Going to push as commit be97b4b.
Since your change was applied there have been 135 commits pushed to the master branch:

  • ff17f49: 8284888: [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."
  • 50d47de: 8286582: Build fails on macos aarch64 when using --with-zlib=bundled
  • 89392fb: 8285820: C2: LCM prioritizes locally dependent CreateEx nodes over projections after 8270090
  • 96d48f3: 8286433: Cache certificates decoded from TLS session tickets
  • 7567627: 8286467: G1: Collection set pruning adds one region too many
  • 82d2570: 8283001: windows-x86-cmp-baseline fails in some jvmti native libs
  • e9f45bb: 8282966: AArch64: Optimize VectorMask.toLong with SVE2
  • 57a7670: 8285612: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java
  • 44a60ce: 8285867: Convert applet manual tests SelectionVisible.java to Frame and automate
  • ccbe8fa: 8282772: JButton text set as HTML content has unwanted padding
  • ... and 125 more: https://git.openjdk.java.net/jdk/compare/4b2c82200fdc01de868cf414e40a4d891e753f89...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 12, 2022
@openjdk openjdk bot closed this May 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2022
@openjdk
Copy link

openjdk bot commented May 12, 2022

@prsadhuk Pushed as commit be97b4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants