Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277090 : jsr166 refresh for jdk19 #8536

Closed
wants to merge 1 commit into from

Conversation

DougLea
Copy link
Contributor

@DougLea DougLea commented May 4, 2022

This is the revised jsr166 refresh for jdk19. See https://bugs.openjdk.java.net/browse/JDK-8285450 and https://bugs.openjdk.java.net/browse/JDK-8277090. Out of caution, this PR removes the unrelated commits from original version.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 reviews required, with at least 1 reviewer)
  • Change requires a CSR request to be approved

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/8536/head:pull/8536
$ git checkout pull/8536

Update a local copy of the PR:
$ git checkout pull/8536
$ git pull https://git.openjdk.java.net/jdk pull/8536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8536

View PR using the GUI difftool:
$ git pr show -t 8536

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/8536.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2022

👋 Welcome back dl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@DougLea The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 4, 2022
@mlbridge
Copy link

mlbridge bot commented May 4, 2022

Webrevs

@DougLea DougLea changed the title 8277090 : jsr166 refresh for jdk19 v2 8277090 : jsr166 refresh for jdk19 May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@DougLea This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277090: jsr166 refresh for jdk19

Reviewed-by: alanb, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 497a94f: 8286138: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on macosx-aarch64
  • 7b7207a: 8280003: C1: Reconsider uses of logical_and immediates in LIRGenerator::do_getObjectSize
  • 17cc713: 8274112: (fc) Tune FileChannel.transferTo()
  • 7424f47: 8286114: [test] show real exception in bomb call in sun/rmi/runtime/Log/checkLogging/CheckLogging.java
  • 29c2e54: 8286092: Remove dead windows stack code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2022
@DougLea
Copy link
Contributor Author

DougLea commented May 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented May 4, 2022

Going to push as commit 00e6c63.
Since your change was applied there have been 7 commits pushed to the master branch:

  • c5a0687: 8285976: compiler/exceptions/OptimizeImplicitExceptions.java can't pass with -XX:+DeoptimizeALot
  • df8c2be: 8279598: Provide adapter from RandomGenerator to Random
  • 497a94f: 8286138: ProblemList javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on macosx-aarch64
  • 7b7207a: 8280003: C1: Reconsider uses of logical_and immediates in LIRGenerator::do_getObjectSize
  • 17cc713: 8274112: (fc) Tune FileChannel.transferTo()
  • 7424f47: 8286114: [test] show real exception in bomb call in sun/rmi/runtime/Log/checkLogging/CheckLogging.java
  • 29c2e54: 8286092: Remove dead windows stack code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 4, 2022
@openjdk openjdk bot closed this May 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2022
@openjdk
Copy link

openjdk bot commented May 4, 2022

@DougLea Pushed as commit 00e6c63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@DougLea DougLea deleted the JDK-8277090v2 branch May 23, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants