-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210 #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…8254814 and JDK-8255210
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
/issue add JDK-8255378 |
@DamonFool This issue is referenced in the PR title - it will now be updated. |
@DamonFool |
@DamonFool The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@DamonFool This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 46 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks @iwanowww for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is arguably trivial and needs no review but here is one anyway.
Thanks @adinn for your review. /integrate |
Pushed as commit 591e7e2. |
Hi all,
As @iwanowww pointed out [1] that there are redundant vector length checks for reductionI [2] and reductionS [3].
It would be better to remove them.
Testing:
Thanks.
Best regards,
Jie
[1] #791 (comment)
[2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L4429
[3] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L4625
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/854/head:pull/854
$ git checkout pull/854