Skip to content

8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210 #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Oct 25, 2020

Hi all,

As @iwanowww pointed out [1] that there are redundant vector length checks for reductionI [2] and reductionS [3].
It would be better to remove them.

Testing:

  • jdk/incubator/vector on both AVX512 and AVX256 machines

Thanks.
Best regards,
Jie

[1] #791 (comment)
[2] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L4429
[3] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/x86.ad#L4625


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x32 Linux x64 Windows x64 macOS x64
Build ✔️ (1/1 passed) ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/854/head:pull/854
$ git checkout pull/854

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2020

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@DamonFool
Copy link
Member Author

/issue add JDK-8255378
/test
/label add hotspot-compiler
/cc hotspot-compiler

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2020
@openjdk
Copy link

openjdk bot commented Oct 25, 2020

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 25, 2020
@openjdk
Copy link

openjdk bot commented Oct 25, 2020

@DamonFool
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Oct 25, 2020

@DamonFool The hotspot-compiler label was already applied.

@mlbridge
Copy link

mlbridge bot commented Oct 25, 2020

Webrevs

Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Oct 26, 2020

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255378: [Vector API] Remove redundant vector length check after JDK-8254814 and JDK-8255210

Reviewed-by: vlivanov, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • 2c9dfc7: 8255234: ZGC: Bulk allocate forwarding data structures
  • b7d483c: 8255245: C1: Fix output of -XX:+PrintCFGToFile to open it with visualizer
  • 5e0a8cd: 8255488: Re-enable some problem listed tests
  • 3f8bd92: 8233556: [TESTBUG] JPopupMenu tests fail on MacOS
  • 4acf634: 8171998: javax/swing/JMenu/4692443/bug4692443.java fails on Windows
  • a804c6a: 8254871: Remove unnecessary string copy in NetworkInterface.c
  • acd0e25: 8255254: Split os::reserve_memory and os::map_memory_to_file interfaces
  • dc85a3f: 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX
  • 1d245c6: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
  • 7a7ce02: 8007632: DES/3DES keys support in PKCS12 keystore
  • ... and 36 more: https://git.openjdk.java.net/jdk/compare/1a94ebc7d79ba1df2c053cfcd331ba185ea91718...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2020
@DamonFool
Copy link
Member Author

Looks good.

Thanks @iwanowww for your review.
May I get a second review for this change?
Thanks.

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is arguably trivial and needs no review but here is one anyway.

@DamonFool
Copy link
Member Author

This is arguably trivial and needs no review but here is one anyway.

Thanks @adinn for your review.
Pushed.

/integrate

@openjdk openjdk bot closed this Oct 28, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2020
@DamonFool DamonFool deleted the JDK-8255378 branch October 28, 2020 11:04
@openjdk
Copy link

openjdk bot commented Oct 28, 2020

Pushed as commit 591e7e2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants