8286172: Create an automated test for JDK-4516019

[srmandal]

Create an automated test for JDK-4516019

Clicking on the increment/decrement buttons of the spinner does not install focus on the spinner or one of its focusable children.

The test validates the same.

This review is for migrating tests from a closed test suite to open.

Testing:
The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8286172: Create an automated test for JDK-4516019

Reviewers

• Phil Race (@prrace - Reviewer)
• Alisen Chung (@alisenchung - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/8546/head:pull/8546
$ git checkout pull/8546

Update a local copy of the PR:
$ git checkout pull/8546
$ git pull https://git.openjdk.org/jdk pull/8546/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8546

View PR using the GUI difftool:
$ git pr show -t 8546

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/8546.diff

[bridgekeeper]

👋 Welcome back smandalika! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@srmandal The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (b5dfdcd3)
• 02: Full - Incremental (69264c7e)
• 01: Full - Incremental (b4fef8cd)
• 00: Full (f1c4278e)

[prrace]

Also you are doing the same thing I've told others not to - look at the path name

test/jdk/javax/swing/4516019/JSpinnerFocusTest.java

what is the point of 4516019 ? Do NOT create an extra directory for no reason.
especially one just numbered for a bugid
and in this case this test should go in the pre-existing JSpinner directory !

[srmandal]

Also you are doing the same thing I've told others not to - look at the path name

test/jdk/javax/swing/4516019/JSpinnerFocusTest.java

what is the point of 4516019 ? Do NOT create an extra directory for no reason. especially one just numbered for a bugid and in this case this test should go in the pre-existing JSpinner directory !

As suggested:
Test removed from the original location.
Test added under pre-existing JSpinner directory.

[srmandal]

/integrate

[openjdk]

@srmandal This pull request has not yet been marked as ready for integration.

[srmandal]

Hi! Can someone please sponsor this PR?

[srmandal]

Hi! Can someone please sponsor this PR?

[srmandal]

Hi! Can someone please sponsor this PR?

[openjdk]

@srmandal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286172: Create an automated test for JDK-4516019

Reviewed-by: prr, achung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1028 new commits pushed to the master branch:

• 0184f46: 8289919: [test] LoadLibraryUnloadTest.java failed with "Failed to unload native library"
• cca91f7: 8290327: Remove java/lang/reflect/callerCache/ReflectionCallerCacheTest.java from ProblemList-Xcomp.txt
• b4e2ce0: 8290366: Remove unused during_conc_mark parameter in HeapRegion::note_self_forwarding_removal_start
• f3abb82: 8268312: Compilation error with nested generic functional interface
• 92deab5: 8028265: Add legacy tz tests to OpenJDK
• 70fce07: 8290246: test fails "assert(init != __null) failed: initialization not found"
• 757a742: 8290177: Improve documentation in G1MMUTracker
• 890bced: 8290264: java/util/concurrent/locks/Lock/OOMEInAQS.java fails with "exit code: 0"
• 3ad3950: Merge
• fd89ab8: 8288112: C2: Error: ShouldNotReachHere() in Type::typerr()
• ... and 1018 more: https://git.openjdk.org/jdk/compare/1bb4de2e2868a539846ec48dd43fd623c2ba69a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[srmandal]

/integrate

[srmandal]

Can someone sponsor this PR?

[openjdk]

@srmandal
Your change (at version b5dfdcd) is now ready to be sponsored by a Committer.

[prrace]

/sponsor

[openjdk]

Going to push as commit e72742e.
Since your change was applied there have been 1046 commits pushed to the master branch:

• b9de0a7: 8284524: Create an automated test for JDK-4422362
• 5ae4320: 8284767: Create an automated test for JDK-4422535
• efed7a7: 8289908: Skip bounds check for cases when String is constructed from entirely used byte[]
• b2010a7: 8287805: Shenandoah: consolidate evacuate-update-root closures
• ea8b75c: 8290334: Update FreeType to 2.12.1
• 6882f0e: 8290013: serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java failed "assert(!in_vm) failed: Undersized StackShadowPages"
• 92067e2: 8290137: riscv: small refactoring for add_memory_int32/64
• 87340fd: 8288883: C2: assert(allow_address || t != T_ADDRESS) failed after JDK-8283091
• bc7a1ea: 8288948: Few J2DBench tests indicate lower primitive drawing performance with metal rendering pipeline
• 84f2314: 8286030: Avoid JVM crash when containers share the same /tmp dir
• ... and 1036 more: https://git.openjdk.org/jdk/compare/1bb4de2e2868a539846ec48dd43fd623c2ba69a5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace @srmandal Pushed as commit e72742e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.